Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

Support module precompilation #61

Merged
merged 8 commits into from
Nov 10, 2021
Merged

Support module precompilation #61

merged 8 commits into from
Nov 10, 2021

Conversation

liamappelbe
Copy link
Contributor

  • Added Module.serialize and Module.deserialize.
  • Added bin/precompile.dart, which loads a .wasm file, compiles the module it, and serializes it.

#40

@liamappelbe liamappelbe requested a review from kevmoo November 9, 2021 22:30
kevmoo
kevmoo approved these changes Nov 9, 2021
View reviewed changes
wasm/bin/precompile.dart Outdated
final outFile = args['out'] as String?;
if (outFile == null) {
print('No output file.');
return 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really set the exit code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. Apparently not. Weird

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set exitCode then return.

@liamappelbe liamappelbe merged commit f998c23 into main Nov 10, 2021
@liamappelbe liamappelbe deleted the aot branch November 10, 2021 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevmoo kevmoo kevmoo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamappelbe @kevmoo