This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(): Add support for void generic argument, which translates to dynamic #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,7 +78,13 @@ export class TranspilerBase { | |||
| maybeVisitTypeArguments(n: {typeArguments?: ts.NodeArray<ts.TypeNode>}) { | |||
| if (n.typeArguments) { | |||
| this.emit('<'); | |||
| this.visitList(n.typeArguments); | |||
| this.visitList(n.typeArguments, ',', (node) => { | |||
There was a problem hiding this comment.
As discussed offline, I think it'd be better to make this code less generic, and only specifically handle the case of a single type argument that's void by just leaving out the type argument.
This code is arguable better by being more generic, but in this case we should be restrictive - we shouldn't support patterns that are going to cause odd APIs for Dart users, when we really only need to support Promise<void> and EventEmitter<void>.
| @@ -75,6 +75,10 @@ export class TranspilerBase { | |||
|
|
|||
| maybeVisitTypeArguments(n: {typeArguments?: ts.NodeArray<ts.TypeNode>}) { | |||
| if (n.typeArguments) { | |||
| // If it's a single type argument `<void>`, ignore it and emit nothing. | |||
There was a problem hiding this comment.
Nit: could you mention that this is for e.g. Promise<void>, and link to dart-lang/sdk#2231 (comment) ?
|
One nit, LGTM otherwise. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to use stuff like:
Which before was harder because we couldn't use
voidas a generic type.