This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Fix line splitter #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the Converter<String, List<String>> interface.
|
cc @keertip |
kevmoo
reviewed
Nov 22, 2017
| /// A trivial conversion turning a Sink<List<String>> into a | ||
| /// Sink<String> | ||
| class _StringSinkWrapper implements Sink<String> { | ||
| Sink<List<String>> _sink; |
|
It looks like this breaks travis @leafpetersen: |
tvolkert
approved these changes
Nov 22, 2017
|
Yes, I think travis failures are flakes or otherwise unrelated. Initial PR passed travis: https://travis-ci.org/google/file.dart/builds/305560605 . Failing run seems to be on the next commit when I added final, but tests still pass locally. |
|
@tvolkert Will you land and publish? I don't have write access here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes dart-lang/sdk#28748 .
LineSplitter has been in an odd state for a while where it implements Converter in Dart 1.0 but not in 2.0. We've made the change in the Dart 2.0 repository to flip it entirely away from Converter. This adds a wrapper implementation that satisfies the Converter interface.