This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
docs(EventHandler): Add EventHandler documentation. #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,45 +2,72 @@ part of angular.core.dom; | |||
|
|
|||
| typedef void EventFunction(event); | |||
|
|
|||
| /** | |||
| * [EventHandler] is responsible for handling events bound using on-* syntax | |||
| * (i.e. on-click="ctrl.doSomething();"). The root of the application has an | |||
There was a problem hiding this comment.
I think code should be enclosed in ...
There was a problem hiding this comment.
Guidelines say nothing about ...
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry, I thought you were speaking about code below.
Add documentation to EventHandler. This change also makes fields and methods within EventHandler, which are not intended for public use, private.
|
Is this a replacement for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation to EventHandler. This change also makes fields and methods within EventHandler, which are not intended for public use, private.