This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feat(parser): Add support for named arguments #762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/core/parser/dynamic_parser_impl.dart lib/core/parser/eval_calls.dart lib/core/parser/parser.dart lib/core/parser/unparser.dart
Conflicts: test/core/parser/parser_spec.dart
| @@ -14,7 +15,10 @@ class DynamicParserImpl { | |||
| DynamicParserImpl(Lexer lexer, this.backend, String input) | |||
| : this.input = input, tokens = lexer.call(input); | |||
|
|
|||
| Token get peek => index < tokens.length ? tokens[index] : Token.EOF; | |||
| Token get next | |||
There was a problem hiding this comment.
This one should fit on a single line
|
Great PR ! Could you squash the commits ? Travis complains about an error with the be dart VM. |
|
This looks like it is ready to go. I will take care of the minor style comments oppon merging. Should be merged tonight. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.