This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(components): TranscludingComponentFactory passes a wrong element to onShadowRoot #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1403,7 +1403,7 @@ class AttachDetachComponent implements AttachAware, DetachAware, ShadowRootAware | |||
|
|
|||
| attach() => logger('attach:@$attrValue; =>$exprValue; =>!$onceValue'); | |||
| detach() => logger('detach'); | |||
| onShadowRoot(shadowRoot) { | |||
| onShadowRoot(ShadowRoot shadowRoot) { | |||
There was a problem hiding this comment.
This looks like the test, would it be possible to add a .not.toThrow() to make it more explicit ?
|
LGTM, 1 minor comment |
vsavkin
force-pushed
the
emulated_components_on_shadow_root
branch
from
20ef6b0 to
22cf079
Compare
…to onShadowRoot Closes dart-archive#1435
vsavkin
force-pushed
the
emulated_components_on_shadow_root
branch
from
22cf079 to
6edd76e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1435