This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
Web Component support: binding to properties #1277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| transformers: | ||
| - angular | ||
| - $dart2js: | ||
| minify: false |
There was a problem hiding this comment.
Any particular reason for minify: false?
|
Would you like to add an E2E test? 😄 |
| { | ||
| "name": "paper-example", | ||
| "version": "0.0.1", | ||
| "homepage": "https://github.com/jbdeboer/angular.dart", |
There was a problem hiding this comment.
| @@ -87,7 +87,7 @@ class DirectiveSelector { | |||
| if (attrName.startsWith("on-")) { | |||
| builder.onEvents[attrName] = value; | |||
| } else if (attrName.startsWith("bind-")) { | |||
| builder.bindAttrs[attrName] = _astParser(value, formatters: _formatters); | |||
| builder.bindAttrs[attrName.substring(5)] = _astParser(value, formatters: _formatters); | |||
There was a problem hiding this comment.
const _BIND_PREFIX_LENGTH = 5; // "bind-" ?
|
LGTM, with a few questions and comments |
|
|
||
| <p> | ||
| Change the value through an ng-model bound input box: | ||
| <input type="text" ng-model="curValue"> |
There was a problem hiding this comment.
<label>Change the value through an ng-model bound input box: <input type="text" ng-model="curValue"></label>
jbdeboer
added a commit
that referenced
this pull request
Aug 5, 2014
dsalsbury
pushed a commit
to dsalsbury/angular.dart
that referenced
this pull request
Aug 7, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.