This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
refactor(ng-repeat): refactor fix for #1015 #1018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chirayuk Could you review this change? |
|
@chirayuk any objection for this to be merged ? I'd like to merge it today |
|
I'm going to merge this. It helps when working on |
|
closed via f6187ae |
vicb
added a commit
to vicb/angular.dart
that referenced
this pull request
Aug 26, 2014
This re-introduce the PR dart-archive#1018: "refactor(ng-repeat): refactor fix for dart-archive#1015" which had been reverted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposal to fix #1015.
#1017 has already been merged but I think this set of change is easier to understand and more efficient.
See the changes vs the original (ie bugged) version.
Also if #774 eventually gets fixed, this version would be easier to deal with.
/cc @chirayuk