Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Expose full Jasmin style syntax externally #549

Closed
pavelgj opened this issue Feb 11, 2014 · 5 comments
Closed

Expose full Jasmin style syntax externally #549

pavelgj opened this issue Feb 11, 2014 · 5 comments
Milestone
Community PRs Wel...

Comments

@pavelgj
Copy link
Contributor

pavelgj commented Feb 11, 2014

Move test/_specs.dart to lib/mocks/specs.dart?
@mhevery mhevery added this to the Community PRs Welcomed milestone Feb 12, 2014
@mhevery
Copy link
Contributor

mhevery commented Feb 12, 2014

I think jasmine dart should be a separate project. Not sure that those hacks we have should be shared with the world.

Moving to Community PRs Welcome

@vsavkin
Copy link
Contributor

vsavkin commented Apr 17, 2014

@mhevery I can try to extract _specs.dart and jasmine_syntax.dart into a separate project (package). I will preserve the current API, but will clean up the implementation and write some unit tests.

This is a spike: https://github.com/vsavkin/JasmineDart

So can I try it?

@vsavkin
Copy link
Contributor

vsavkin commented Apr 24, 2014

UPDATE:
I extracted (more like reimplemented) the Jasmine syntax. You can find the project here: https://github.com/vsavkin/guinness. If you are interested in using something like this instead of jasmine_syntax.dart and _specs.dart, please let me know, so I can create a PR.

@pavelgj
Copy link
Contributor Author

pavelgj commented Apr 24, 2014

@vsavkin This is awesome!

vsavkin added a commit to vsavkin/angular.dart that referenced this issue May 2, 2014
@vsavkin
chore(jasmine_syntax): use the guinness testing library instead of ja…
2c48a35 
…smine_syntax

Replace the jasmine syntax implemented by jasmine_syntax.dart and _specs.dart with Guinness:
- remove jasmine_syntax.dart
- update _specs.dart to use guinness instead of jasmine_syntax.dart
- change karma config files to initialize guinness
- replace all references to jasmine with guinness

Closes dart-archive#549
vsavkin added a commit to vsavkin/angular.dart that referenced this issue May 2, 2014
@vsavkin
chore(jasmine_syntax): use the guinness testing library instead of ja…
e66b6d1 
…smine_syntax

Replace the jasmine syntax implemented by jasmine_syntax.dart and _specs.dart with Guinness:
- remove jasmine_syntax.dart
- update _specs.dart to use guinness instead of jasmine_syntax.dart
- change karma config files to initialize guinness
- replace all references to jasmine with guinness

Closes dart-archive#549
vsavkin added a commit to vsavkin/angular.dart that referenced this issue May 2, 2014
@vsavkin
chore(jasmine_syntax): use the guinness testing library instead of ja…
241d26b 
…smine_syntax

Replace the jasmine syntax implemented by jasmine_syntax.dart and _specs.dart with Guinness:
- remove jasmine_syntax.dart
- update _specs.dart to use guinness instead of jasmine_syntax.dart
- change karma config files to initialize guinness
- replace all references to jasmine with guinness

Closes dart-archive#549
@vsavkin vsavkin mentioned this issue May 2, 2014
Closed
@vsavkin
Copy link
Contributor

vsavkin commented May 2, 2014

Just submitted a pull request: #994

@mhevery mhevery closed this as completed in 5c6a18e May 7, 2014
jbdeboer pushed a commit that referenced this issue May 20, 2014
@vsavkin @jbdeboer
chore(jasmine_syntax): use the guinness testing library instead of ja…
e47e673 
…smine_syntax

Replace the jasmine syntax implemented by jasmine_syntax.dart and _specs.dart with Guinness:
- remove jasmine_syntax.dart
- update _specs.dart to use guinness instead of jasmine_syntax.dart
- change karma config files to initialize guinness
- replace all references to jasmine with guinness

Closes #549

Closes #994

Conflicts:
	pubspec.yaml
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@vsavkin
chore(jasmine_syntax): use the guinness testing library instead of ja…
a59f246 
…smine_syntax

Replace the jasmine syntax implemented by jasmine_syntax.dart and _specs.dart with Guinness:
- remove jasmine_syntax.dart
- update _specs.dart to use guinness instead of jasmine_syntax.dart
- change karma config files to initialize guinness
- replace all references to jasmine with guinness

Closes dart-archive#549

Closes dart-archive#994
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@vsavkin
chore(jasmine_syntax): use the guinness testing library instead of ja…
d34d3b8 
…smine_syntax

Replace the jasmine syntax implemented by jasmine_syntax.dart and _specs.dart with Guinness:
- remove jasmine_syntax.dart
- update _specs.dart to use guinness instead of jasmine_syntax.dart
- change karma config files to initialize guinness
- replace all references to jasmine with guinness

Closes dart-archive#549

Closes dart-archive#994
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
Community PRs Welcomed
Development

Successfully merging a pull request may close this issue.

chore(jasmine_syntax): use guinness instead of jasmine_syntax vsavkin/angular.dart
3 participants
@vsavkin @mhevery @pavelgj