Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

ComponentDirectiveInjector should return this.parent when asked for DirectiveInjector #1351

Closed
rkirov opened this issue Aug 13, 2014 · 0 comments
Closed

ComponentDirectiveInjector should return this.parent when asked for DirectiveInjector #1351

rkirov opened this issue Aug 13, 2014 · 0 comments
Assignees
@rkirov

Comments

@rkirov
Copy link
Contributor

rkirov commented Aug 13, 2014

and return this only when asked for ComponentDirectiveInjector.
@rkirov rkirov self-assigned this Aug 13, 2014
rkirov added a commit to rkirov/angular.dart that referenced this issue Aug 22, 2014
@rkirov
feat(directive-injector): component directive injector injects parent
946f1c6 
When asked for DirectiveInjector, ComponentDirectiveInjector injects
parent and injects self, when asked for ComponentDirectiveInjector
explicitly.

Closes dart-archive#1351
@rkirov rkirov mentioned this issue Aug 22, 2014
Closed
rkirov added a commit to rkirov/angular.dart that referenced this issue Aug 22, 2014
@rkirov
feat(directive-injector): component directive injector injects parent
8d44364 
BREAKING_CHANGE:
When asked for DirectiveInjector, ComponentDirectiveInjector injects
parent. When asked for ComponentDirectiveInjector it injects self.

Before:
MyComponent(DirectiveInjector di) { }

After:
MyComponent(ComponentDirectiveInjector cdi, DirectiveInjector di) { }

where before di = after cdi, before di.parent = after di.

Closes dart-archive#1351
rkirov added a commit to rkirov/angular.dart that referenced this issue Aug 25, 2014
@rkirov
feat(directive-injector): component directive injector injects parent
bf9b473 
BREAKING_CHANGE:
When asked for DirectiveInjector, ComponentDirectiveInjector injects
parent. When asked for ComponentDirectiveInjector it injects self.

Before:
MyComponent(DirectiveInjector di) { }

After:
MyComponent(ComponentDirectiveInjector cdi, DirectiveInjector di) { }

where before di = after cdi, before di.parent = after di.

Closes dart-archive#1351
rkirov added a commit that referenced this issue Aug 25, 2014
@rkirov
feat(directive-injector): component directive injector injects parent
87d72ef 
BREAKING_CHANGE:
When asked for DirectiveInjector, ComponentDirectiveInjector injects
parent. When asked for ComponentDirectiveInjector it injects self.

Before:
MyComponent(DirectiveInjector di) { }

After:
MyComponent(ComponentDirectiveInjector cdi, DirectiveInjector di) { }

where before di = after cdi, before di.parent = after di.

Closes #1351
@rkirov rkirov closed this as completed in 3af9434 Aug 25, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rkirov rkirov

Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(directive-injector): component directive injector injects parent rkirov/angular.dart
1 participant
@rkirov