Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Simplify the code of the dccd #1128

Closed
vicb opened this issue Jun 9, 2014 · 2 comments
Closed

Simplify the code of the dccd #1128

vicb opened this issue Jun 9, 2014 · 2 comments

Comments

@vicb
Copy link
Contributor

vicb commented Jun 9, 2014

We use DuplicateMaps in order to track linked and unlinked elements of collection.

DuplicateMap.put has an insertBefore argument.

However this argument is never used, removing it would allow simplifying the code.

Could we safely drop it ?

/cc @mhevery
@mhevery
Copy link
Contributor

mhevery commented Jun 9, 2014

If we don't use it, and if tests pass after you remove it, then it must have gotten there organically, and it should be removed.

@vicb
Copy link
Contributor Author

vicb commented Jun 9, 2014

Tests do pass, I'll take care of that

vicb added a commit that referenced this issue Jun 9, 2014
@vicb
refactor(dccd): Drop the insertBefore arg from DuplicateMap.put()
f4132ea 
Closes #1128

The insertBefore argument is never used in the current code
@vicb vicb mentioned this issue Jun 9, 2014
Closed
@vicb vicb closed this as completed in f54451b Jul 31, 2014
vicb added a commit that referenced this issue Aug 5, 2014
@vicb @chirayuk
refactor(dccd): Drop the insertBefore arg from DuplicateMap.put()
9061ffb 
Fixes #1128
Closes #1132

The insertBefore argument is never used in the current code
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Aug 7, 2014
@vicb
refactor(dccd): Drop the insertBefore arg from DuplicateMap.put()
9aba6fb 
Fixes dart-archive#1128
Closes dart-archive#1132

The insertBefore argument is never used in the current code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(dccd): Drop the insertBefore arg from DuplicateMap.put() vicb/angular.dart
2 participants
@mhevery @vicb