Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Commit

Permalink
fix(generator): remove invalid sort on elements
Browse files Browse the repository at this point in the history
cacheUris are sorted later.  sorting the elements can be invalid (e.g.
SimpleStringLiteral has == but no compareTo)

Closes #554
  • Loading branch information
chirayuk authored and mhevery committed Feb 12, 2014
1 parent b59f744 commit e2a00ab
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/tools/template_cache_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ class TemplateCollectingVisitor {
var paramName = namedArg.name.label.name;
if (paramName == 'preCacheUrls') {
assertList(namedArg.expression).elements
..sort()
..forEach((expression) =>
cacheUris.add(assertString(expression).stringValue));
}
Expand Down

0 comments on commit e2a00ab

Please sign in to comment.