2.0 #93
Merged
2.0 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use v-model and remove internal searchInput watcher * switch to input event handler for v-model support * address outstanding TODOs for 3.0 breaking changes * remove deprecated events onInputChange, onClick, onBlur, onFocus, onSelected * remove class, name defaults * remove initialValue as now it can be set via v-model * docs(demo) update demo to use v-model * tests(*) WIP updating snapshots verifying functionality
* setValue on input instead of setData on wrapper * remove tests for deprecations * add back husky precommit hook
* refactor(computed) move sections and size to computed props. It didn't make much sense to have the computedSections being calculated manually so now it is a computed prop. This helps with perf since computed props have memoization. This also allows to also remove computedSize so we can remove side effects and difficult to understand computations. This also completely removes the watcher, which is something that has needed to happen since I introduced it. * fix(initialValue) since we removed initialValue, make v-model work. * refactor(getSize) rename getSize to computed prop totalResults * docs(readme) update readme to have all the new stuff v-model, etc * docs(storybook) update stories to match new feats
* use serializer preferred by vue-test-utils and update snapshots
* fix(size) factor in limit in totalResults size * refactor(*) Remove dead code identified by test coverage * test(listeners) add test for event listener on destroy
Repository owner
deleted a comment from
codecov-io
Feb 10, 2019
Repository owner
deleted a comment from
codecov-io
Feb 12, 2019
* add demo to show flexibility / no results example
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 80.33% 86.25% +5.91%
==========================================
Files 1 1
Lines 178 160 -18
Branches 54 44 -10
==========================================
- Hits 143 138 -5
+ Misses 11 4 -7
+ Partials 24 18 -6
Continue to review full report at Codecov.
|
|
@darrenjennings Hello, can you please tell me if the work on the second version will continue? |
|
@batFormat indeed it will! I'm hoping to release 2.0 in the next month as I will be preparing to present on it at a meetup. Hit a road block locally that I haven't had time to devote to, but expect something before July. 🤞 |
* adjust storybook + app demo * add back outline for focus in demos * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 2️⃣
Working PR for 2.0 of vue-autosuggest.
See Roadmap: #92
Publishing these changes to
betatag on npm as ready.Fixes #52
Codesandbox Demo: https://codesandbox.io/s/7z7p8mx2y1
Changelog
use v-model and remove internal searchInput watcher
switch to input event handler for v-model support
address outstanding TODOs for 2.0 breaking changes
remove deprecated events onInputChange, onClick, onBlur, onFocus,
onSelected
remove class, name defaults
remove initialValue as now it can be set via v-model
docs(demo) update demo to use v-model
refactor(computed) move sections and size to computed props. It didn't
make much sense to have the computedSections being calculated manually
so now it is a computed prop. This helps with perf since computed props
have memoization. This also allows to also remove computedSize so we can
remove side effects and difficult to understand computations. This also
completely removes the watcher, which is something that has needed to
happen since I introduced it.
fix(initialValue) since we removed initialValue, make v-model work.
refactor(getSize) rename getSize to computed prop totalResults
docs(readme) update readme to have all the new stuff v-model, etc
docs(storybook) update stories to match new feats