Add props for list & list item className #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 80.11% 80.33% +0.22%
==========================================
Files 1 1
Lines 176 178 +2
Branches 53 55 +2
==========================================
+ Hits 141 143 +2
Misses 12 12
Partials 23 23
Continue to review full report at Codecov.
|
| @@ -66,7 +67,8 @@ const DefaultSection = { | |||
| class: { | |||
| "autosuggest__results_item-highlighted": | |||
| this.getItemIndex(key) == this.currentIndex, | |||
| autosuggest__results_item: true | |||
| autosuggest__results_item: true, | |||
| [this.section.listItemClassName]: this.section.listItemClassName | |||
There was a problem hiding this comment.
I don't mind adding this, but instead of restricting it to class, we should instead bind any attributes using v-bind which can accept an object.
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Class name props for list & list item
Why: I used bootstrap with autosuggest and I was unable to set classes for the suggestions
ulandlielements. I can now add the bootstrap class names to those elements.How: Added listClassName and listItemClassName to section configs
Checklist: