Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for multiple instances with open results #78

Merged
merged 1 commit into from Nov 11, 2018
Merged

fix: Fix for multiple instances with open results #78

merged 1 commit into from Nov 11, 2018

Conversation

scottadamsmith
Copy link
Contributor

Fixes the ability to navigate through and select results when mulltiple autosuggests are present and open

Issue #73

What: Fix to ensure correct results and input are targeted when interacting with a open autosuggest result while another open autosuggest result is present.

Checklist:

  • Documentation - N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov
Copy link

codecov bot commented Nov 9, 2018

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   81.71%   81.71%           
=======================================
  Files           1        1           
  Lines         175      175           
  Branches       53       53           
=======================================
  Hits          143      143           
  Misses         11       11           
  Partials       21       21
Impacted Files Coverage Δ
src/Autosuggest.vue 81.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909a6b7...b9db5d2. Read the comment docs.

@darrenjennings
Copy link
Owner

Thanks @scottadamsmith I'll review soon!

Copy link
Owner

@darrenjennings darrenjennings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automatischsuchen is unnecessary in the test data prop but tested locally outside of unit tests and everything is looking good. Will merge and add a storybook to demonstrate this working before publishing. Thanks so much! 🚀

@darrenjennings darrenjennings merged commit 9aaff8a into darrenjennings:master Nov 11, 2018
@scottadamsmith scottadamsmith deleted the pr/issue-73-multiple-instances branch November 12, 2018 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants