Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scroll) clicking on scroll doesn't close autosuggest #64

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

darrenjennings
Copy link
Owner

  • destroy event listeners in beforeDestroy lifecycle
  • tests(listener) trigger mousedown as well

Fixes #63

* destroy event listeners in beforeDestroy lifecycle
* tests(listener) trigger mousedown as well
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #64 into master will decrease coverage by 0.55%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   82.73%   82.18%   -0.56%     
==========================================
  Files           1        1              
  Lines         168      174       +6     
  Branches       51       51              
==========================================
+ Hits          139      143       +4     
- Misses          9       11       +2     
  Partials       20       20
Impacted Files Coverage Δ
src/Autosuggest.vue 82.18% <57.14%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b37f7d3...d4f3973. Read the comment docs.

@darrenjennings darrenjennings merged commit 5eb0f9a into master Oct 11, 2018
@darrenjennings darrenjennings deleted the fix/63-scrollclick-listeners branch October 11, 2018 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant