Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events) add suggestion as event @suggestion #62

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

darrenjennings
Copy link
Owner

Fixes #58

  • chore(eslint) add eslint vue/recommended configuration and have
    autosuggest lib conform
  • chore(rollup) uglify esm module for smaller lib size
  • chore(storybook) add story for suggestion event
  • test(events) add tests for suggestion event/deprecation warnings

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

- chore(eslint) add eslint vue/recommended configuration and have
autosuggest lib conform
- chore(rollup) uglify esm module for smaller lib size
- chore(storybook) add story for suggestion event
- test(events) add tests for suggestion event/deprecation warnings
@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #62 into master will decrease coverage by 0.08%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   82.82%   82.73%   -0.09%     
==========================================
  Files           1        1              
  Lines         163      168       +5     
  Branches       48       51       +3     
==========================================
+ Hits          135      139       +4     
  Misses          9        9              
- Partials       19       20       +1
Impacted Files Coverage Δ
src/Autosuggest.vue 82.73% <83.33%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcb63d...686cf8c. Read the comment docs.

@darrenjennings darrenjennings merged commit b37f7d3 into master Oct 3, 2018
@darrenjennings darrenjennings deleted the feat/58-suggestion-as-event branch October 3, 2018 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant