Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rendering): fixed unnecessary re-rendering #33

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

darrenjennings
Copy link
Owner

  • when input was clicked, list would rerender. Now checking that what you clicked is input and not rerendering.

From #32

  • Ready to be merged

* when input was clicked, list would rerender. Now checking that what you clicked is input and not rerendering.

From #32
@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #33 into master will decrease coverage by 0.95%.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33      +/-   ##
=======================================
- Coverage   80.95%   80%   -0.96%     
=======================================
  Files           1     1              
  Lines         147   150       +3     
  Branches       40    41       +1     
=======================================
+ Hits          119   120       +1     
- Misses         10    11       +1     
- Partials       18    19       +1
Impacted Files Coverage Δ
src/Autosuggest.vue 80% <50%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3591aaf...a848454. Read the comment docs.

@darrenjennings darrenjennings merged commit 920c885 into master Mar 26, 2018
@darrenjennings darrenjennings deleted the fix/32-rerendering-onclick branch March 26, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant