Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/a11y role combobox #194

Merged
merged 8 commits into from
Jun 18, 2020

Conversation

42tte
Copy link
Contributor

@42tte 42tte commented Jun 18, 2020

What:
Fixes usage of wai-aria role combobox.

Why:
Adding a wai-aria role to an element overrides that elements native role and semantics. Meaning the input text field is no longer presented as an input text field but as a combobox.

How:
Implemented the combobox according to the documentation https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html

Checklist:

  • Documentation N/A
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov-commenter
Copy link

Codecov Report

Merging #194 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files           1        1           
  Lines         175      175           
  Branches       51       51           
=======================================
  Hits          149      149           
  Misses         11       11           
  Partials       15       15           
Impacted Files Coverage Δ
src/Autosuggest.vue 85.14% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33dd54e...1b24406. Read the comment docs.

@darrenjennings
Copy link
Owner

Thanks for this @42tte! Looks like a great change, and I'm surprised this wasn't caught sooner. Either way, I added a codecov yaml as it seems the bot is failing the patch phase. I think it's because of all the white space changes. If you rebase latest master I think it should trigger a new codecov run and disable the patch phase entirely.

@darrenjennings darrenjennings merged commit 07dabec into darrenjennings:master Jun 18, 2020
@42tte
Copy link
Contributor Author

42tte commented Jun 22, 2020

@darrenjennings Thank you for the super fast response! Could I please ask for a npm publish as well 😀

@darrenjennings
Copy link
Owner

@42tte yes sorry about that, thought I did. 2.2.0 now available on the registry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants