-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/a11y role combobox #194
Fix/a11y role combobox #194
Conversation
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=======================================
Coverage 85.14% 85.14%
=======================================
Files 1 1
Lines 175 175
Branches 51 51
=======================================
Hits 149 149
Misses 11 11
Partials 15 15
Continue to review full report at Codecov.
|
Thanks for this @42tte! Looks like a great change, and I'm surprised this wasn't caught sooner. Either way, I added a codecov yaml as it seems the bot is failing the |
…-autosuggest into fix/a11y-role-combobox
@darrenjennings Thank you for the super fast response! Could I please ask for a |
@42tte yes sorry about that, thought I did. 2.2.0 now available on the registry! |
What:
Fixes usage of wai-aria role combobox.
Why:
Adding a wai-aria role to an element overrides that elements native role and semantics. Meaning the input text field is no longer presented as an input text field but as a combobox.
How:
Implemented the combobox according to the documentation https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html
Checklist: