Updated setters for Labels for both Post types and Taxonomies and set correct format for taxonomies links, post type supports and add post type taxonomies

[0v3rth3d4wn]

The labels for the CPT weren't properly created and I saw that the set method was being passed a different arguments and did not mirror the construct method.

[0v3rth3d4wn]

Updated with an additional commit to set the correct format for register_post_type and register_taxonomy, particularly for 'supports', 'taxonomies' and 'links'.

[darrenjacoby]

@0v3rth3d4wn thanks for the PR. My only concern is the removal of this section, https://github.com/soberwp/intervention/pull/48/files#diff-99e7358da92c4ba8da69d861d8cd75876a8d3f5ab1acd52a14dafb01f01c3a5bL72-L76

It converts keys using - to _ for registering post types. I liked this as it allowed users to maintain consistency with the other options of the plugin, whereas WordPress uses underscores.

Let me know your thoughts there.

[darrenjacoby]

@0v3rth3d4wn @jrgd ,

I have merged and made some upgrades (#3302825), which should enable you to also pass in a string in the option.

eg; 'genre.links' => 'book' or 'genre.links' => ['post, 'book'] would both be valid.

Also reverts the removal of the key conversion for WP (- to _).

I have tested this side, but would always appreciate confirmation that it solves the issue. Thanks again for your help!

[0v3rth3d4wn]

@darrenjacoby,

I cherry picked this and it works - yes. Thank you!