Add "disable-attachment-pages" module

[runofthemill]

Added code from https://gschoppe.com/wordpress/disable-attachment-pages/ - I tried to match the structure to other modules, but other than making the function names camel case the code is unchanged.

There's a filter available (gjs_attachment_slug_prefix) which I'm not sure is worth keeping, and an unused function (makeAttachmentsPrivate()) which I asked about and got this response:

The gjs_attachment_slug_prefix filter is provided so that users can change the default of wp-attachment to another value, in case they need to for some reason. This is important because the slug wp-attachment-«original-file-slug» will still be reserved by WordPress, so it is possible that on some sites this could cause collision issues.

make_attachments_private(){} was originally hooked to the register_post_type_args filter, as it should cause the attachment post type to not reserve slugs. However, attachments currently ignore the standard post type arguments. I’ve re-added this hook to the to the plugin, in the hope that someday, WordPress may add support these arguments properly.

I haven't done thorough testing, but enabling this module w/ intervention does indeed disable attachment pages, rewrites the URLs, and seems to work as advertised!

[knowler]

This would be great. I just noticed a small issue which I don’t think was intentional.

[knowler]

☝️ I’m assuming this wasn’t meant for the PR. 🙂

[runofthemill]

ah, that was so I could use it with composer - forgot subsequent commits would affect the PR =D

I'll fix now :)

[runofthemill]

@knowler fixed!

[darrenjacoby]

@runofthemill are you able to update the README.md?

[runofthemill]

I am - but I just noticed an issue when trying to upload media, so I'm going to look into that as well!

[darrenjacoby]

@runofthemill thanks!

[runofthemill]

@darrenjacoby finally got around to looking at this. fixed the issue, but honestly I'm still a little perplexed by the gjs_attachment_slug_prefix filter - I can't figure out where wp-attachment is used ¯_(ツ)_/¯

Lemme know if you want to keep or drop that filter, then I'll update the readme.

[darrenjacoby]

@runofthemill thanks! I think we should drop the gjs_attachment_slug_prefix filter, what do you think?

[runofthemill]

I'll drop it, don't think it's necessary...can always revisit later if necessary!

[runofthemill]

@darrenjacoby removed & README updated ✌️

[darrenjacoby]

@runofthemill thanks! I'll get this merged soon, I'm going to be doing some other updates to intervention at the same time.

[runofthemill]

I mean I only took 6 months to get this finished.... :P

[LukeAbell]

Any chance we could get this merged? Thanks!

[darrenjacoby]

Merging and will release as part of a new version soon.

@runofthemill 6 months pales in comparison to my 1.5 year merge timeline it seems 😬