Support for ypub & zpub

[dspicher]

Hi, first of all thanks a lot for this great library!

I was wondering whether you would consider adding support for the ypub and ypub versions of extended keys?

I would be happy to take a stab at this with a PR if you signal willingness to support this.

[darosior]

Hi, sorry to only see this now. My thoughts with regards to ypubs and zpubs are detailed in this PR adding support for them: #21.

TL;DR: i think people should migrate to proper output descriptors instead but i understand the need for interacting with legacy systems.

As mentioned there, i'm happy to take a PR implementing the conversion and stating in the doc that it should be avoided if possible. The PR linked above seems abandoned so feel free to take a stab at this!

[kanzure]

ENCODING_PREFIX in general does not support the electrum types, like Vpub: https://electrum.readthedocs.io/en/latest/xpub_version_bytes.html#specification

These are used in bip174 PSBTs.

That said, I do see your other message:

hardcoding of specific script types inside the encoding of an extended public key is an unscalable and terrible layer violation

[darosior]

In what PSBT field are script-related xpub prefixes used? The key of the PSBT_GLOBAL_XPUB field is explicitly defined as:

The 78 byte serialized extended public key as defined by BIP 32

The serialization defined by BIP 32 (including all prefixes defined there) is implemented in this library, so it shouldn't be incompatible with PSBTs?

That said, I do see your other message: [...]

Yes. Just to be clear: while i don't think it's a good idea and don't want to perpetrate this practice through this library, i do want to make it reasonably possible for downstream users to integrate with current and past tooling.
So i'm happy to have a compatibility layer to ypub, zpub, vpub, Vpub, Zpub, whateverpub as long as it's clearly stated it's bAd ™️.

[kanzure]

ok, sounds like electrum PSBT is just non-standard?

[darosior]

Looks like so. :/ ------- Original Message ------- Le mardi 23 août 2022 à 1:14 PM, Bryan Bishop ***@***.***> a écrit :

…

ok, sounds like electrum PSBT is just non-standard? — Reply to this email directly, [view it on GitHub](#26 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3FZK4B64BOLGVEGBYELV2SXADANCNFSM5MMEFBPA). You are receiving this because you commented.Message ID: ***@***.***>