Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libm: Remove unused rpath config #1358

Merged
merged 1 commit into from
May 1, 2023

Conversation

zhaofengli
Copy link
Contributor

@zhaofengli zhaofengli commented Apr 23, 2023

Doesn't seem to be necessary.

Original PR description

The rpath is resolved within the Darling sandbox, not from the install location.

Anyways, I don't think it's needed at all at the moment.

@bugaevc
Copy link
Member

bugaevc commented Apr 24, 2023

The rpath thing apparently comes from the time when we had /etc/dylib.conf. I can't imagine what it could be useful for now. Should we just drop it?

@zhaofengli zhaofengli changed the title libm: Fix install rpath libm: Remove unused rpath config Apr 26, 2023
@facekapow facekapow merged commit e34366d into darlinghq:master May 1, 2023
@zhaofengli zhaofengli deleted the fix-libm-rpath branch May 1, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants