CFURL and CFAttributedString patches for TextEdit #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugaevc
requested changes
Apr 12, 2023
bugaevc
reviewed
Apr 17, 2023
|
The only thing blocking this PR is the discussion regarding whether the symbols from LaunchServices should be loaded and unloaded for each function call or loaded once statically, and whether that loading should have global or local scope. I'd like to examine what Apple does, however I do not have access to a Mac and am not sure how to do so. I think I've handled everything except for squashing the commits(I'm waiting to do this until I verify the code is correct) |
bugaevc
reviewed
May 26, 2023
CKegel
force-pushed
the
Add_UTIs
branch
2 times, most recently
from
38bd89e to
6107bdb
Compare
CKegel
changed the title
facekapow
requested changes
Oct 20, 2023
facekapow
approved these changes
Oct 22, 2023
bugaevc
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Type Identification to CFURl(and by extension NSURL) using the LaunchServices
UTTypeCreatePreferredIdentifierForTag(...)API.