Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax DNG black level parsing #521

Conversation

kmilos
Copy link
Contributor

@kmilos kmilos commented Sep 20, 2023

Use the default BlackLevelRepeatDim (1,1) if the single entry value is 1

This e.g. allows the black level of Pentax K-3 Mark III Monochrome DNG from RPU to be parsed instead of being ignored:

Exif.SubImage1.BlackLevelRepeatDim           Short       1  1
Exif.SubImage1.BlackLevel                    Long        1  2048

Alternatively, could read the one value if count is 1, and copy it?

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.01% ⚠️

Comparison is base (2f1e314) 59.10% compared to head (bc952cf) 59.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #521      +/-   ##
===========================================
- Coverage    59.10%   59.10%   -0.01%     
===========================================
  Files          232      232              
  Lines        13898    13900       +2     
  Branches      1938     1938              
===========================================
+ Hits          8214     8215       +1     
- Misses        5551     5552       +1     
  Partials       133      133              
Flag Coverage Δ
benchmarks 8.18% <0.00%> (-0.01%) ⬇️
integration 47.51% <75.00%> (+<0.01%) ⬆️
linux 57.01% <75.00%> (-0.01%) ⬇️
macOS 18.68% <0.00%> (-0.01%) ⬇️
rpu_u 47.51% <75.00%> (+<0.01%) ⬆️
unittests 18.22% <0.00%> (-0.01%) ⬇️
windows ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/librawspeed/decoders/DngDecoder.cpp 52.67% <75.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LebedevRI
Copy link
Member

What were they thinking? :/
Was this reported to Pentax?

In this case, i think i'm, at most, okay with

Alternatively, could read the one value if count is 1, and copy it?

@kmilos
Copy link
Contributor Author

kmilos commented Sep 20, 2023

Was this reported to Pentax?

Don't think so. You know where/how?

@kmilos kmilos force-pushed the kmilos/dng_blacklevelrepeatdim_fallback branch from 19bfb85 to bc952cf Compare September 21, 2023 07:34
Use the default BlackLevelRepeatDim (1,1) if the single entry value is 1
@kmilos kmilos force-pushed the kmilos/dng_blacklevelrepeatdim_fallback branch from bc952cf to 1be0462 Compare September 21, 2023 13:25
@LebedevRI
Copy link
Member

Was this reported to Pentax?

Don't think so. You know where/how?

I haven't managed to find any kind of non-user-facing side,
so i guess the usual "straight-to-spam" https://www.ricoh.com/contact

@LebedevRI
Copy link
Member

@Milos thank you.

But this really needs to be reported to Ricoh/Pentax.

@LebedevRI LebedevRI merged commit a7ea097 into darktable-org:develop Sep 21, 2023
41 of 45 checks passed
@kmilos kmilos deleted the kmilos/dng_blacklevelrepeatdim_fallback branch September 21, 2023 20:28
@kmilos
Copy link
Contributor Author

kmilos commented Sep 21, 2023

Will do. I guess it doesn't hurt and improves the chances if you do it as well?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants