-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax DNG black level parsing #521
Relax DNG black level parsing #521
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #521 +/- ##
===========================================
- Coverage 59.10% 59.10% -0.01%
===========================================
Files 232 232
Lines 13898 13900 +2
Branches 1938 1938
===========================================
+ Hits 8214 8215 +1
- Misses 5551 5552 +1
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
What were they thinking? :/ In this case, i think i'm, at most, okay with
|
Don't think so. You know where/how? |
19bfb85
to
bc952cf
Compare
Use the default BlackLevelRepeatDim (1,1) if the single entry value is 1
bc952cf
to
1be0462
Compare
I haven't managed to find any kind of non-user-facing side, |
@Milos thank you. But this really needs to be reported to Ricoh/Pentax. |
Use the default BlackLevelRepeatDim (1,1) if the single entry value is 1
This e.g. allows the black level of Pentax K-3 Mark III Monochrome DNG from RPU to be parsed instead of being ignored:
Alternatively, could read the one value if count is 1, and copy it?