-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for multiframe DNGs #350
base: develop
Are you sure you want to change the base?
Conversation
Hi i was wondering, is this work so far acceptable into rawspeed? |
Codecov Report
@@ Coverage Diff @@
## develop #350 +/- ##
===========================================
- Coverage 57.70% 57.44% -0.26%
===========================================
Files 207 207
Lines 11994 12008 +14
Branches 288 285 -3
===========================================
- Hits 6921 6898 -23
- Misses 4949 4987 +38
+ Partials 124 123 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b7d51d5
to
a7cf21a
Compare
using shared_ptr instead of RawImage, also not all places require reference counting
a7cf21a
to
2949e7e
Compare
Hi I implemented support for multiframe DNGs. Teste with penatx PixelShift DNG.
warning: this breaks external API, merging must be coordinated with changes in darktable.
my plan is to change darktable pipeline to support multiple frames, and merge them in demosaic module.
work done:
-refactored RawImage and RawImageData classes to store multiple frames.
-modified internal api
-modified DngDecoder to decode all frames
todo:
-speed optimizations
-cleanup?
possible future:
-modify all decoders to support multiple frames