introduce --first option #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With --first, all processes are terminated after the first process terminated (regardless of the exit code). The exit code is the exit code of the process that terminated first.
|
Hey @andrenarchy thanks for the PR 😄 Looks pretty good - but do you want to add some tests for it? Then I'll happily give this a merge. |
|
I'm currently trying to write tests. However, I don't get why the exit code is 2 in all tests. Where does the 2 come from? |
|
I think |
|
you have to use the unit tests of #25. The others are faulty, sorry for that. |
|
I merged it into dev with #29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
--first, all child processes are terminated after the first child process terminated (regardless of the exit code). The exit code of the parent process is the exit code of the child process that terminated first.The option makes sense, e.g., in the setting of e2e tests where you start a http server process and then run tests against the http server. When the test process terminates, also the http server should be killed. For example:
The exit code of the
parallelshellprocess then is the exit code of thehttp-testsprocess.