-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable changing of background color #56
Comments
Hi- Thanks for sending feedback. Would you mind explaining what makes the colouring scheme weird? It would be great if you could attach a screenshot of a weird view. ASCIIGenome should use white background and the same colours regardless of the user's colouring scheme. In theory there should be no interference between ASCIIGenome's and user's colours. However since I almost always use black on white (i.e. MacOS default), it may well be that I missed something when other colour options are used. (I could add the option of settings colours if that helps but first let's see if your issue is due to a bug) |
Indeed, this is a bug. Empty cells should be painted white. Sorry about that and thanks for reporting it. I should be able to fix it quite soon and I'll post here as soon as the fix is done. |
Hi- Would you mind trying the new version v1.2.1? It should have this bug fixed. The bioconda repository (if you use it) is not up to date just now. To download and use the new version, as per docs, you can do:
|
Thank you for your quick reaction! And sorry, but version 1.2.1 does not fix this issue on my end. It still looks the same. Let me know if you need more information about my system to further investigate this. |
Hi- Sorry about that. Could you post information on the operating system you are using (Mac, Linux, etc) and the terminal you use? Also, just checking, make sure you are running v1.2.1 instead of the previous installation (e.g. by Finally, would you be able to send the minimal commands that generate the issue, like
(From your screenshot it appears your terminal is correctly interpreting the ansi escapes for colours, so I don't see why the fix doesn't work...) At the moment I have only access to a Mac laptop and I can reproduce the issue with v1.2.0, but I get it fixed in 1.2.1. Thank you! |
I used your example:
I am using Terminator 0.97-2ubuntu0.1 on Linux Mint 17.3 64 bit. I forgot to mention that I was starting ASCIIGenome from within tmux; outside of tmux the problem disappears with v1.2.1. tmux is set to "screen-256color". Hope that helps. Looking forward to your response. Thank you! |
Thanks for feedback - I'm not familiar with tmux but I will install it and try to reproduce the issue. For the time being, you could try to start
|
Hi- If you are still interested in this issue (and in ASCIIGenome in general), I uploaded version 1.3.0 which should fix some issues with tmux and most importantly allows custom configuration of the colours. See FAQ. Version 1.3.0 also introduces the sys command to execute system commands (I find this quite useful to execute commands like Please let me know of any further issues. |
Awesome! Thank you! |
Ok, thanks! I'm going to close this issue but do get back if you have any troubles. |
Currently a white background is used for all text, which looks weird on terminals that have a different background color such as black (used by the super-hacker-y types). It would be great if the user could change the background color or set it to transparency.
The text was updated successfully, but these errors were encountered: