Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4 #5

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Issue 4 #5

merged 2 commits into from
Oct 19, 2021

Conversation

dariobauer
Copy link
Owner

Fixes and improvements to the validation of authorization codes and access tokens.

  • Moved the access token check from the _create_headers method to the _get_token method as it makes more sense to check it there;
  • Fixed the access token check to look for a json web token rather than the length of the string, resolves issue Access token length check is too strict #4;
  • Update the auth code extraction to use regex rather than make assumptions on the position within the returned url.

@dariobauer dariobauer added bug Something isn't working enhancement New feature or request labels Oct 19, 2021
@dariobauer dariobauer self-assigned this Oct 19, 2021
@dariobauer dariobauer merged commit 53c8d61 into main Oct 19, 2021
@dariobauer dariobauer deleted the issue-4 branch October 19, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant