Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when using download_file with verbose=False #29

Closed
tulbureandreit opened this issue Feb 14, 2022 · 1 comment
Closed

Bug when using download_file with verbose=False #29

tulbureandreit opened this issue Feb 14, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@tulbureandreit
Copy link

Hello,

When using download_file (file, max_conn, verbose=False), the system returns an error, that a variable was referenced before assignment.

I found that this is a result of a bug: you mis-idented a print at line 1342 in _onedrive.py.

Can you fix it ? Thank you!

Keep up the good work.

@dariobauer dariobauer self-assigned this Feb 15, 2022
@dariobauer dariobauer added the bug Something isn't working label Feb 15, 2022
dariobauer added a commit that referenced this issue Feb 15, 2022
dariobauer added a commit that referenced this issue Feb 15, 2022
@dariobauer
Copy link
Owner

dariobauer commented Feb 15, 2022

Hi Tulbure, thanks for raising this issue and finding the bug.
I have fixed this by unindenting the part_name definition.

Unfortunately the download_file method is currently not automatically tested as async tests are a bit more complex.

This fix will be issued as release 0.3.1 on PyPI in the coming days. You can also install the active dev version using pip install https://github.com/dariobauer/graph-onedrive/archive/main.zip.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants