Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the yaml dependency to v3? #206

Closed
fubarhouse opened this issue Mar 10, 2022 · 2 comments
Closed

Update the yaml dependency to v3? #206

fubarhouse opened this issue Mar 10, 2022 · 2 comments

Comments

@fubarhouse
Copy link

Why hello!

Been using mergo for some time and was recently hit by something (link below). Seems the solution is to not use yaml v2 however I've noticed that mergo does use v2 of the yaml package. Is there any chance you'd consider updating it?

go-yaml/yaml#139
@fubarhouse fubarhouse mentioned this issue Mar 10, 2022
Open
mudler added a commit to mudler/luet that referenced this issue Mar 21, 2022
@mudler
🐛 Update yaml to v3
114d489 
The recent switch to mergo throws in a yaml version which is affected
by go-yaml/yaml#139, and caused
rancher/elemental-toolkit#1189.

Updating to yaml.v3 where it was affected.

Note mergo still uses v2, so this can be problematic on other areas
darccio/mergo#206.
darccio added a commit that referenced this issue May 25, 2022
@darccio
Upgrade yaml to v3
f86e6f6 
As requested in "Update the yaml dependency to v3? #206".
@darccio darccio mentioned this issue May 25, 2022
Merged
@darccio
Copy link
Owner

darccio commented May 25, 2022

@fubarhouse @mudler I've merged #212 to upgrade to v3.

@darccio darccio closed this as completed May 25, 2022
@mudler
Copy link

mudler commented May 25, 2022

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@darccio @mudler @fubarhouse