Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an 'engine_args' option similar to tinytex's. #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EmmanuelCharpentier
Copy link

The issue #172 reported the difficulties to use tikzDevice in a \LaTeX file using packages needing the -shell-escape option to {pdf|xe|lua}latex in order to access the filesystem and system commands.

This patch request implements a solution to issue #172. it adds an argument engine_args similar to the one present in tinytex, with a corresponding global option tikzEngineArgs.

This patch request passes R CMD check --as-cran. I have installed it on R 3.4.4 and 3.5.1.

Of note : this is not sufficient to use it transparently for use with knitr ; in order to use t transparently, you also tave to set tinytex.engine_args to the same -shell-escape value. I think that this is a bug in the way my system (emacs) invokes the various compilers, an consider it a different problem.

Home this helps...

Copy link
Member

@rstub rstub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Can you please remove the white-space / formatting changes, e.g. in R/tikz.R? That way the PR would be easier to evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants