Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove runtime version override #642

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Oct 23, 2024

Description

  • Removes the version override that pins the runtime to v1.14.1
  • Removes the previously required base64 decoding hack for the jobs api

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mikeee mikeee requested review from a team as code owners October 23, 2024 10:42
@mikeee mikeee marked this pull request as draft October 23, 2024 10:44
@mikeee
Copy link
Member Author

mikeee commented Oct 23, 2024

  • Will need to update the example for the jobs api

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.37%. Comparing base (6c59092) to head (54ca43d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   62.52%   62.37%   -0.15%     
==========================================
  Files          56       56              
  Lines        4139     4205      +66     
==========================================
+ Hits         2588     2623      +35     
- Misses       1425     1454      +29     
- Partials      126      128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mikeee mikeee marked this pull request as ready for review November 5, 2024 19:23
@yaron2 yaron2 merged commit e52d60c into dapr:main Nov 20, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants