-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the case where appid contains at least one upperletter #1233
Conversation
07a75f3
to
aa79f43
Compare
Signed-off-by: Nicolas Chaussé <[email protected]> Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
Signed-off-by: Nicolas Chaussé <[email protected]> Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
…use case Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to avoid the URL parsing if the principal scenario is unblocked without it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
+ Coverage 67.17% 67.20% +0.02%
==========================================
Files 174 174
Lines 5986 5991 +5
Branches 667 668 +1
==========================================
+ Hits 4021 4026 +5
Misses 1798 1798
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas Chaussé <[email protected]>
Alright I've updated the code in this way? |
Description
The .NET SDK Client for Dapr does not handle the case where the app id contains an upper character for HTPP service invocation, because it uses the property Host of the URI, which is case insensitive (always in lower case), inside the class InvocationHandler.
The change is to use the appid sent when creating the HTTPClient or if there is no appId, use the host issued by the original string of the URI to get the correct app id (i.e. case sensitive).
The DaprClient can always be used for another appid if the user put an absolute URI.
There is no breaking change.
Issue reference
#[#937]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: