Handle the case where appid contains at least one upperletter #1233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWEESTY
changed the title
TWEESTY
changed the title
TWEESTY
force-pushed
the
master
branch
2 times, most recently
from
07a75f3
to
aa79f43
Compare
TWEESTY
changed the title
TWEESTY
changed the title
TWEESTY
changed the title
Signed-off-by: Nicolas Chaussé <[email protected]> Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
Signed-off-by: Nicolas Chaussé <[email protected]> Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
…use case Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
Signed-off-by: TWEESTY <[email protected]> Signed-off-by: Nicolas Chaussé <[email protected]>
philliphoff
reviewed
Feb 14, 2024
philliphoff
requested changes
Feb 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
+ Coverage 67.17% 67.20% +0.02%
==========================================
Files 174 174
Lines 5986 5991 +5
Branches 667 668 +1
==========================================
+ Hits 4021 4026 +5
Misses 1798 1798
Partials 167 167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Nicolas Chaussé <[email protected]>
Alright I've updated the code in this way? |
philliphoff
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The .NET SDK Client for Dapr does not handle the case where the app id contains an upper character for HTPP service invocation, because it uses the property Host of the URI, which is case insensitive (always in lower case), inside the class InvocationHandler.
The change is to use the appid sent when creating the HTTPClient or if there is no appId, use the host issued by the original string of the URI to get the correct app id (i.e. case sensitive).
The DaprClient can always be used for another appid if the user put an absolute URI.
There is no breaking change.
Issue reference
#[#937]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: