Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aws): revamp aws docs + iam role anywhere profile #4456

Merged
merged 11 commits into from
Dec 12, 2024

Conversation

sicoyle
Copy link
Contributor

@sicoyle sicoyle commented Dec 4, 2024

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

#4130

@sicoyle sicoyle requested review from a team as code owners December 4, 2024 19:23
Signed-off-by: Samantha Coyle <[email protected]>
@hhunter-ms hhunter-ms added this to the 1.15 milestone Dec 4, 2024
@sicoyle
Copy link
Contributor Author

sicoyle commented Dec 4, 2024

is there a way i can view the results of my changes somewhere in the PR @hhunter-ms ?

Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review - thanks @sicoyle!

@hhunter-ms
Copy link
Collaborator

is there a way i can view the results of my changes somewhere in the PR @hhunter-ms ?

@sicoyle there are a couple of ways to preview the docs site with your changes:

  • open a PR from upstream instead of your fork. I did this for easier review of the conversation api PR
  • if you can't do that, you can build the docs site locally using these instructions

Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle sicoyle requested a review from hhunter-ms December 4, 2024 20:59
@sicoyle
Copy link
Contributor Author

sicoyle commented Dec 5, 2024

do I need to do anything else to get this merged @hhunter-ms ?

@hhunter-ms
Copy link
Collaborator

do I need to do anything else to get this merged @hhunter-ms ?

@sicoyle I'm just waiting for a quick review from @msfussell - should be merged today!

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

@@ -30,8 +30,8 @@ Prefer loading credentials via the default AWS configuration in scenarios such a
| Attribute | Required | Description | Example |
| --------- | ----------- | ----------- | ----------- |
| `region` | Y | AWS region to connect to. | "us-east-1" |
| `accessKey` | N | AWS Access key id. | "AKIAIOSFODNN7EXAMPLE" |
| `secretKey` | N | AWS Secret access key, used alongside `accessKey`. | "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY" |
| `accessKey` | N | AWS Access key id. Will be required in Dapr 1.17. | "AKIAIOSFODNN7EXAMPLE" |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment correct about Dapr v1.17? Do you mean v1.16 the next release?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msfussell I left a comment about this too - here's @sicoyle's response: #4456 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, so it's 1.17 bc we're deprecating all aws prefixed fields. So, I've marked accessKey and secretKey as not required to help support the transition, so the docs are denoted and the metadata bundle as well to state that it will be required in dapr 1.17 as we rm the duplicate fields that had the aws prefix, and then the accessKey and secretKey fields can become required again.

@hhunter-ms hhunter-ms merged commit 93477ab into dapr:v1.15 Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authenticate components to services using Dapr SPIFFE identity X.509 certificate
3 participants