-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aws): revamp aws docs + iam role anywhere profile #4456
Conversation
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
is there a way i can view the results of my changes somewhere in the PR @hhunter-ms ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick review - thanks @sicoyle!
daprdocs/content/en/developing-applications/integrations/AWS/authenticating-aws.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/integrations/AWS/authenticating-aws.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/integrations/AWS/authenticating-aws.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/integrations/AWS/authenticating-aws.md
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/integrations/AWS/authenticating-aws.md
Outdated
Show resolved
Hide resolved
@sicoyle there are a couple of ways to preview the docs site with your changes:
|
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
do I need to do anything else to get this merged @hhunter-ms ? |
@sicoyle I'm just waiting for a quick review from @msfussell - should be merged today! |
…o feat-iam-roles-anywhere
Signed-off-by: Samantha Coyle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
@@ -30,8 +30,8 @@ Prefer loading credentials via the default AWS configuration in scenarios such a | |||
| Attribute | Required | Description | Example | | |||
| --------- | ----------- | ----------- | ----------- | | |||
| `region` | Y | AWS region to connect to. | "us-east-1" | | |||
| `accessKey` | N | AWS Access key id. | "AKIAIOSFODNN7EXAMPLE" | | |||
| `secretKey` | N | AWS Secret access key, used alongside `accessKey`. | "wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY" | | |||
| `accessKey` | N | AWS Access key id. Will be required in Dapr 1.17. | "AKIAIOSFODNN7EXAMPLE" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment correct about Dapr v1.17? Do you mean v1.16 the next release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msfussell I left a comment about this too - here's @sicoyle's response: #4456 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, so it's 1.17 bc we're deprecating all aws prefixed fields. So, I've marked accessKey and secretKey as not required to help support the transition, so the docs are denoted and the metadata bundle as well to state that it will be required in dapr 1.17 as we rm the duplicate fields that had the aws prefix, and then the accessKey and secretKey fields can become required again.
daprdocs/content/en/developing-applications/integrations/AWS/authenticating-aws.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/integrations/AWS/authenticating-aws.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/integrations/AWS/authenticating-aws.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/integrations/AWS/authenticating-aws.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Samantha Coyle <[email protected]>
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Bring changes from docs: update fields as they are optional #4371 to v1.15 docs.
Revamp AWS docs given the complete refactor of things from the following contrib PRs:
feat(kafka): iam roles anywhere + assume role auth profiles components-contrib#3606
feat(postgres): add iam roles anywhere auth profile components-contrib#3604
feat(iam auth): allow iam roles anywhere auth profile components-contrib#3591
fix get aws creds from environment components-contrib#3617
Add new auth profiles for assuming an IAM role and for roles anywhere
Issue reference
#4130