Use Google Analytics 4 ID for v1.6 via head-end hook #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrice Chalin <[email protected]>
Signed-off-by: Patrice Chalin <[email protected]>
Signed-off-by: Patrice Chalin <[email protected]>
11 tasks
chalin
changed the title
chalin
commented
Nov 18, 2022
| @@ -27,7 +27,7 @@ disableKinds = ["taxonomy", "term"] | |||
|
|
|||
| # Google Analytics | |||
| [services.googleAnalytics] | |||
| id = "UA-149338238-3" | |||
| id = "UA-00000000-0" | |||
There was a problem hiding this comment.
This is a bogus GA ID so that the Docsy page-feedback feature keeps on working.
chalin
commented
Nov 18, 2022
Comment on lines
+5
to
+12
| <script> | ||
| window.dataLayer = window.dataLayer || []; | ||
| function gtag(){dataLayer.push(arguments);} | ||
| gtag('js', new Date()); | ||
|
|
||
| gtag('config', 'G-60C6Q1ETC1'); | ||
| </script> |
There was a problem hiding this comment.
The real GA4 ID is setup here.
chalin
force-pushed
the
chalin-gp-ga4-v1.6-2022-11-18
branch
from
3b1663b to
addee52
Compare
Signed-off-by: Patrice Chalin <[email protected]>
chalin
force-pushed
the
chalin-gp-ga4-v1.6-2022-11-18
branch
from
addee52 to
c38434d
Compare
chalin
commented
Nov 19, 2022
Comment on lines
+38
to
+40
| continue-on-error: true | ||
| run: | | ||
| for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name || exit 1 ;done | ||
|
|
||
| for name in `find . -name "*.md"`; do echo -e "------\n$name" ; mm.py -l $name ;done |
There was a problem hiding this comment.
Applied the same solution that I did to the v1.7 docs, given that v1.6 are also legacy docs. Link-checking will report errors but not fail the build.
|
Build is green now, PTAL @greenie-msft et al. |
|
Stale PR, paging all reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the version of Hugo used to build v1.6 docs is too old, it doesn't support GA4, so I added the GA4 ID via a head-end hook.
/cc @msfussell @greenie-msft