Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snssqs): if topic dne + we dont create, then we skip the actual err #3630

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sicoyle
Copy link
Contributor

@sicoyle sicoyle commented Dec 10, 2024

Description

I'm testing all AWS native components for verifying my IAM Roles Anywhere changes. I was seeing weird stuff for snssqs, but it's bc if you set the disableEntityManagement to where it will not create the topic, and then try to publish to a topic that DNE, then you see this err:

{"errorCode":"ERR_PUBSUB_PUBLISH_MESSAGE","message":"error when publishing to topic samnewesttopic in pubsub samsnssqsnew: error publishing to topic: samnewesttopic with topic ARN : InvalidParameter: Invalid parameter: TopicArn Reason: An ARN must have at least 6 elements, not 1\n\tstatus code: 400, request id: 1888a509-1936-55d1-91f1-fadb798e05e3","details":[{"@type":"type.googleapis.com/google.rpc.ResourceInfo","description":"error when publishing to topic samnewesttopic in pubsub samsnssqsnew: error publishing to topic: samnewesttopic with topic ARN : InvalidParameter: Invalid parameter: TopicArn Reason: An ARN must have at least 6 elements, not 1\n\tstatus code: 400, request id: 1888a509-1936-55d1-91f1-fadb798e05e3","owner":"","resource_name":"samsnssqsnew","resource_type":"pubsub"},{"@type":"type.googleapis.com/google.rpc.ErrorInfo","domain":"dapr.io","metadata":{"error":"error publishing to topic: samnewesttopic with topic ARN : InvalidParameter: Invalid parameter: TopicArn Reason: An ARN must have at least 6 elements, not 1\n\tstatus code: 400, request id: 1888a509-1936-55d1-91f1-fadb798e05e3","topic":"samnewesttopic"},"reason":"DAPR_PUBSUB_PUBLISH_MESSAGE"}]}

With my changes to now capture this err, it is clear what is actually going on:

{"errorCode":"ERR_PUBSUB_PUBLISH_MESSAGE","message":"error when publishing to topic samnewesttopic in pubsub samsnssqsnew: error getting topic ARN for samnewesttopic: topic not found","details":[{"@type":"type.googleapis.com/google.rpc.ResourceInfo","description":"error when publishing to topic samnewesttopic in pubsub samsnssqsnew: error getting topic ARN for samnewesttopic: topic not found","owner":"","resource_name":"samsnssqsnew","resource_type":"pubsub"},{"@type":"type.googleapis.com/google.rpc.ErrorInfo","domain":"dapr.io","metadata":{"error":"error getting topic ARN for samnewesttopic: topic not found","topic":"samnewesttopic"},"reason":"DAPR_PUBSUB_PUBLISH_MESSAGE"}]}

Also IAM Roles Anywhere works fine for this component 😇

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@sicoyle sicoyle requested review from a team as code owners December 10, 2024 15:55
Signed-off-by: Samantha Coyle <[email protected]>
@sicoyle
Copy link
Contributor Author

sicoyle commented Dec 10, 2024

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Dec 10, 2024

Components conformance test

🔗 Link to Action run

Commit ref: 6aae517

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • bindings.azure.eventhubs
  • pubsub.aws.snssqs.terraform
  • state.azure.cosmosdb

@dapr-bot
Copy link
Collaborator

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 6aae517

@dapr-bot
Copy link
Collaborator

dapr-bot commented Dec 10, 2024

Components certification test

🔗 Link to Action run

Commit ref: 6aae517

❌ Some certification tests failed

These tests failed:

  • bindings.azure.servicebusqueues
  • bindings.cron
  • pubsub.gcp.pubsub
  • pubsub.mqtt3
  • state.azure.cosmosdb
  • state.sqlserver

Signed-off-by: Samantha Coyle <[email protected]>
@yaron2
Copy link
Member

yaron2 commented Dec 20, 2024

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Dec 20, 2024

Components conformance test

🔗 Link to Action run

Commit ref: 5ce5d97

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • pubsub.aws.snssqs.terraform
  • state.azure.cosmosdb
  • state.sqlserver

@dapr-bot
Copy link
Collaborator

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 5ce5d97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants