fix(metadata): make access/secret keys optional #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samantha Coyle <[email protected]>
JoshVanL
suggested changes
Oct 8, 2024
| @@ -91,14 +91,10 @@ func (m *PostgresAuthMetadata) ValidateAwsIamFields() (string, string, string, e | |||
| if awsRegion == "" { | |||
| return "", "", "", errors.New("metadata property AWSRegion is missing") | |||
| } | |||
| // Note: access key and secret keys can be optional | |||
There was a problem hiding this comment.
Does the metadata yaml need to be updated?
There was a problem hiding this comment.
There was a problem hiding this comment.
I see, the yaml was previously wrong, now it's correct 😆
JoshVanL
approved these changes
Oct 8, 2024
yaron2
approved these changes
Oct 8, 2024
elena-kolevska
pushed a commit
to elena-kolevska/components-contrib
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Samantha Coyle <[email protected]> Signed-off-by: Elena Kolevska <[email protected]>
elena-kolevska
pushed a commit
to elena-kolevska/components-contrib
that referenced
this pull request
Oct 24, 2024
Signed-off-by: Samantha Coyle <[email protected]> Signed-off-by: Elena Kolevska <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the event someone is using AWS IAM authentication, then they can leverage the loading of default credentials here:
components-contrib/common/authentication/aws/aws.go
Line 105 in 9012bdc
Alternatively, they can supply the access key and secret key. Therefore, the accesskey and secretkey fields are optional, not required.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: