-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing bug with new Avro conversion when message values are NULL #3388
Fixing bug with new Avro conversion when message values are NULL #3388
Conversation
Signed-off-by: Patrick Assuied <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]>
…bout it not being wrapped in a CloudEvent Signed-off-by: Patrick Assuied <[email protected]>
56842d2
to
eff81be
Compare
@yaron2 These certification tests are really brittle. I doubt my changes have caused rabbitmq and mqtt3 tests to fail... Any path forward other than retrying these tests over an over? Should they be skipped until made more resilient? |
The current issue in cert tests seems realted to a certificate issue:
I remember this was an issue previously due to some certificates being hardcoded in tests and expiring... Yeah these hard-coded certs have expired... https://github.com/dapr/components-contrib/blob/main/tests/certification/bindings/rabbitmq/mtls_sasl_external/components/mtls_external/rabbitmq-mtls.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes
Co-authored-by: Alessandro (Ale) Segala <[email protected]> Signed-off-by: Patrick Assuied <[email protected]>
Co-authored-by: Alessandro (Ale) Segala <[email protected]> Signed-off-by: Patrick Assuied <[email protected]>
@ItalyPaleAle how should we deal with these certification errors due to certs having expired. They've been failing since Feb... In the past, you figured out a way to generate certs as part of the test (though I cannot find the code anymore)... |
That's for RabbitMQ not Kafka, right? If you want to contribute a PR to fix that, it'd be nice :) I think accepting hardcoded certs was a mistake. We should have generated the certs on-the-fly. |
Co-authored-by: Alessandro (Ale) Segala <[email protected]> Signed-off-by: Patrick Assuied <[email protected]>
Don't really have the time right this minute but would like my PR to go through quickly as we're eager to use the feature. I can try to contribute later but I'm struggling to run these tests locally... |
I am not concerned with the RabbitMQ tests failing in this PR. If Kafka tests pass, we can merge |
Signed-off-by: Patrick Assuied <[email protected]>
…r#3388) Signed-off-by: Patrick Assuied <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]>
Signed-off-by: Patrick Assuied <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]>
Description
Fixing bug with new Avro conversion when message values are NULL
Issue reference
#3387
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: