[Security] Remove orphaned unmaintained Temporal component #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernd Verst <[email protected]>
artursouza
approved these changes
Nov 29, 2023
|
Please, collect feedback from other maintainers too. |
yaron2
approved these changes
Nov 29, 2023
|
@ItalyPaleAle told me via chat he's ok with it! |
ItalyPaleAle
approved these changes
Nov 29, 2023
|
LGTM. Can we get a +1 (or at least a "not -1") from @mukundansundar and @daixiang0 too as runtime maintainers too? |
This component is not registered in runtime anyway. So it has no impact there. If something comes up (though that's currently impossible) we can always revert this very self contained PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The only 4 currently open high and medium priority security issues are in our Temporal test infrastructure code. The temporal component is not registered in Dapr runtime and no development has gone into this.
Since this component was never used in any Dapr release I am electing to remove this component from contrib for maintenance reasons. Recall that we were not able to add it to runtime because it increased the memory consumption of Dapr more than the allowable threshold.