Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial OPA middleware certification tests #3233

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

stuartleeks
Copy link
Contributor

Signed-off-by: Stuart Leeks [email protected]

Description

Added initial certification tests for OPA HTTP middleware

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@stuartleeks stuartleeks marked this pull request as ready for review November 20, 2023 16:39
@stuartleeks stuartleeks requested review from a team as code owners November 20, 2023 16:39
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay! This test looks good to me and I think it's valuable to have.

However, the CI seems to be failing, can you please take a look at that?

Also, the test needs to be enabled in the CI. That is done by adding it to https://github.com/dapr/components-contrib/blob/main/.github/scripts/test-info.mjs

Signed-off-by: Stuart Leeks <[email protected]>
Signed-off-by: Stuart Leeks <[email protected]>
@stuartleeks
Copy link
Contributor Author

@ItalyPaleAle Thanks - I've added the test and run make modtidy-all. Will see whether that has helped the build

@ItalyPaleAle
Copy link
Contributor

@ItalyPaleAle Thanks - I've added the test and run make modtidy-all. Will see whether that has helped the build

Yup, and it works :) https://github.com/dapr/components-contrib/actions/runs/7420243520/job/20205105873?pr=3233

Thanks!

@ItalyPaleAle ItalyPaleAle merged commit b1525a4 into dapr:main Jan 5, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants