-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle object not found error in bindings: S3, Azure Blob Storage, GCP Bucket, Huawei OBS #3223
Conversation
Signed-off-by: sadath-12 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is a great start.
In addition to the comment I left, can you please update the certification tests to add a case of testing retrieving a file that doesn't exist?
Signed-off-by: sadath-12 <[email protected]>
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 13779ba |
Components certification testCommit ref: 13779ba ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: 13779ba ✅ All conformance tests passedAll tests have reported a successful status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are almost done - you still need to format this file properly - that is done with the gofumpt
tool. There are other files that need to be formatted as well - see the linter error (make lint
to run the linter locally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @berndverst 🙂
Signed-off-by: sadath-12 <[email protected]>
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: fee4335 |
Components conformance testCommit ref: fee4335 ✅ All conformance tests passedAll tests have reported a successful status |
Components certification testCommit ref: fee4335 ❌ Some certification tests failedThese tests failed:
|
Description
Added specific error handling to object not found mentioning the key so user is not frustated with unnecessary long errors
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #2526 _
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: