Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds outbox metadata fields #3186

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Conversation

elena-kolevska
Copy link
Contributor

Description

Adds metadata fields needed for the outbox pattern

Checklist

Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska elena-kolevska marked this pull request as ready for review October 21, 2023 13:00
@elena-kolevska elena-kolevska requested review from a team as code owners October 21, 2023 13:00
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this PR targeting release-1.12?

.build-tools/pkg/metadataschema/validators.go Outdated Show resolved Hide resolved
.build-tools/pkg/metadataschema/validators.go Outdated Show resolved Hide resolved
.build-tools/pkg/metadataschema/validators.go Outdated Show resolved Hide resolved
Co-authored-by: Alessandro (Ale) Segala <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska elena-kolevska changed the base branch from release-1.12 to master October 21, 2023 22:08
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 507 lines in your changes are missing coverage. Please review.

Comparison is base (5384d54) 34.94% compared to head (888482d) 35.46%.
Report is 15 commits behind head on master.

❗ Current head 888482d differs from pull request most recent head 086aacb. Consider uploading reports for the commit 086aacb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3186      +/-   ##
==========================================
+ Coverage   34.94%   35.46%   +0.52%     
==========================================
  Files         241      240       -1     
  Lines       29914    29442     -472     
==========================================
- Hits        10453    10443      -10     
+ Misses      18579    18118     -461     
+ Partials      882      881       -1     
Files Coverage Δ
bindings/influx/influx.go 56.62% <ø> (ø)
configuration/azure/appconfig/appconfig.go 72.86% <ø> (ø)
internal/component/postgresql/metadata.go 85.71% <100.00%> (ø)
metadata/utils.go 63.82% <100.00%> (+0.75%) ⬆️
nameresolution/consul/configuration.go 94.82% <100.00%> (+0.13%) ⬆️
state/sqlite/sqlite_metadata.go 88.46% <100.00%> (+34.22%) ⬆️
internal/component/postgresql/postgresql_query.go 61.42% <0.00%> (ø)
state/postgresql/postgresql.go 0.00% <0.00%> (ø)
state/cockroachdb/cockroachdb.go 0.00% <0.00%> (ø)
state/sqlite/sqlite_migrations.go 90.32% <89.65%> (+20.72%) ⬆️
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elena-kolevska
Copy link
Contributor Author

Why is this PR targeting release-1.12?

Thanks for the review @ItalyPaleAle. I moved it to master.

Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@ItalyPaleAle ItalyPaleAle merged commit ddc10f7 into dapr:master Oct 22, 2023
173 of 179 checks passed
@ItalyPaleAle ItalyPaleAle added this to the v1.13 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants