Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx SQS: Error during Dapr Shutdown and Message Polling Behavior Issue (AWS) #3174

Merged
merged 24 commits into from
Nov 1, 2023
Merged

FIx SQS: Error during Dapr Shutdown and Message Polling Behavior Issue (AWS) #3174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
ff1e7fd
removal of lock for concurrent map usage and move to sync.Map
amimimor Sep 28, 2023
023fd64
linting
amimimor Sep 28, 2023
b23500d
consistant log messaging for sns topic issues
amimimor Sep 28, 2023
8ce917e
wip on subscriber
amimimor Sep 28, 2023
f58e402
subscripition manager first draft
amimimor Oct 3, 2023
0748f1c
Signed-off-by: Amit Mor <[email protected]>
amimimor Oct 3, 2023
c99a3c0
add logger and init of chan that was missing
amimimor Oct 3, 2023
a8387e1
conformance tests passing
amimimor Oct 3, 2023
8505c23
before wip pull back to head
amimimor Oct 8, 2023
cb79e4e
refactors
amimimor Oct 5, 2023
d0b44ee
wip. fixing failed tests
amimimor Oct 8, 2023
d906239
comments and debug msgs
amimimor Oct 8, 2023
ba0e5b5
golangci-lint fixes
amimimor Oct 12, 2023
6102db7
Merge branch 'master' into 3156-shutdown-and-handlers-map
amimimor Oct 15, 2023
a3aea77
fine-grained locking
amimimor Oct 16, 2023
e7f16b7
fine-grained topic lock
amimimor Oct 24, 2023
7d55a4e
xsync v3 from v2
amimimor Oct 26, 2023
57da5d1
named return
amimimor Oct 26, 2023
63a5b9a
remove singleton
amimimor Oct 26, 2023
163489b
switch on change event action
amimimor Oct 26, 2023
41bef96
singleton bugfix
amimimor Oct 26, 2023
4d8b903
refactoring, interfaces, removal of singletons
amimimor Oct 26, 2023
36e742a
Merge branch 'master' into 3156-shutdown-and-handlers-map
ItalyPaleAle Oct 31, 2023
44dc373
init once to struct member
amimimor Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ require (
github.com/oracle/oci-go-sdk/v54 v54.0.0
github.com/pashagolub/pgxmock/v2 v2.12.0
github.com/patrickmn/go-cache v2.1.0+incompatible
github.com/puzpuzpuz/xsync/v3 v3.0.0
github.com/rabbitmq/amqp091-go v1.8.1
github.com/redis/go-redis/v9 v9.2.1
github.com/sendgrid/sendgrid-go v3.13.0+incompatible
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1732,6 +1732,8 @@ github.com/prometheus/statsd_exporter v0.21.0/go.mod h1:rbT83sZq2V+p73lHhPZfMc3M
github.com/prometheus/statsd_exporter v0.22.7 h1:7Pji/i2GuhK6Lu7DHrtTkFmNBCudCPT1pX2CziuyQR0=
github.com/prometheus/statsd_exporter v0.22.7/go.mod h1:N/TevpjkIh9ccs6nuzY3jQn9dFqnUakOjnEuMPJJJnI=
github.com/prometheus/tsdb v0.7.1/go.mod h1:qhTCs0VvXwvX/y3TZrWD7rabWM+ijKTux40TwIPHuXU=
github.com/puzpuzpuz/xsync/v3 v3.0.0 h1:QwUcmah+dZZxy6va/QSU26M6O6Q422afP9jO8JlnRSA=
github.com/puzpuzpuz/xsync/v3 v3.0.0/go.mod h1:VjzYrABPabuM4KyBh1Ftq6u8nhwY5tBPKP9jpmh0nnA=
github.com/rabbitmq/amqp091-go v1.8.1 h1:RejT1SBUim5doqcL6s7iN6SBmsQqyTgXb1xMlH0h1hA=
github.com/rabbitmq/amqp091-go v1.8.1/go.mod h1:+jPrT9iY2eLjRaMSRHUhc3z14E/l85kv/f+6luSD3pc=
github.com/rcrowley/go-metrics v0.0.0-20181016184325-3113b8401b8a/go.mod h1:bCqnVzQkZxMG4s8nGwiZ5l3QUCyqpo9Y+/ZMZ9VjZe4=
Expand Down
2 changes: 1 addition & 1 deletion pubsub/aws/snssqs/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type snsSqsMetadata struct {
// aws partition in which SNS/SQS should create resources.
internalPartition string `mapstructure:"-"`
// name of the queue for this application. The is provided by the runtime as "consumerID".
SqsQueueName string `mapstructure:"consumerID" mdignore:"true"`
SqsQueueName string `mapstructure:"consumerID" mdignore:"true"`
// name of the dead letter queue for this application.
SqsDeadLettersQueueName string `mapstructure:"sqsDeadLettersQueueName"`
// flag to SNS and SQS FIFO.
Expand Down
Loading
Loading