Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes GCP components failing to authenticate #3169

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fixes GCP components failing to authenticate #3169

merged 2 commits into from
Oct 9, 2023

Conversation

elena-kolevska
Copy link
Contributor

Description

GCP cert tests were failing after switching to dapr/dapr master, due to the way the context used for initialising the connection to GCP was managed.

Issue reference

This PR closes #3129

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@elena-kolevska elena-kolevska requested review from a team as code owners October 9, 2023 10:11
@JoshVanL
Copy link
Contributor

JoshVanL commented Oct 9, 2023

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 1cc2e4c

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: 1cc2e4c

❌ Some conformance tests failed

These tests failed:

  • state.azure.cosmosdb

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: 1cc2e4c

❌ Some certification tests failed

These tests failed:

  • pubsub.gcp.pubsub
  • pubsub.kafka
  • pubsub.pulsar
  • state.redis

@JoshVanL
Copy link
Contributor

JoshVanL commented Oct 9, 2023

@elena-kolevska Can you change the target branch to be release-1.12?

@elena-kolevska elena-kolevska changed the base branch from master to release-1.12 October 9, 2023 10:54
@elena-kolevska
Fixes GCP components failing to authenticate
dce93c3 
Signed-off-by: Elena Kolevska <[email protected]>
@elena-kolevska
Fixes typo
f50b23a 
Signed-off-by: Elena Kolevska <[email protected]>
@JoshVanL
Copy link
Contributor

JoshVanL commented Oct 9, 2023

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: f50b23a

❌ Some certification tests failed

These tests failed:

  • pubsub.aws.snssqs
  • pubsub.pulsar

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: f50b23a

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: f50b23a

❌ Some conformance tests failed

These tests failed:

  • state.azure.cosmosdb

@artursouza
Copy link
Member

/ok-to-test

2 similar comments
@artursouza
Copy link
Member

/ok-to-test

@artursouza
Copy link
Member

/ok-to-test

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: f50b23a

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: f50b23a

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: f50b23a

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • bindings.azure.servicebusqueues
  • bindings.azure.storagequeues
  • pubsub.pulsar

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: f50b23a

✅ All conformance tests passed

All tests have reported a successful status

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: f50b23a

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • pubsub.azure.eventhubs
  • pubsub.azure.servicebus.topics
  • pubsub.rabbitmq
  • state.azure.tablestorage

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: f50b23a

❌ Some conformance tests failed

These tests failed:

  • bindings.azure.eventgrid
  • state.azure.cosmosdb

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components certification test

🔗 Link to Action run

Commit ref: f50b23a

❌ Some certification tests failed

These tests failed:

  • bindings.azure.eventhubs
  • pubsub.aws.snssqs
  • pubsub.azure.eventhubs
  • pubsub.azure.servicebus.topics
  • pubsub.pulsar

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: f50b23a

@dapr-bot
Copy link
Collaborator

dapr-bot commented Oct 9, 2023 •
edited
Loading

Components conformance test

🔗 Link to Action run

Commit ref: f50b23a

❌ Some conformance tests failed

These tests failed:

  • pubsub.azure.eventhubs

This was referenced Oct 9, 2023
Merged
Closed
@ItalyPaleAle ItalyPaleAle merged commit 5384d54 into dapr:release-1.12 Oct 9, 2023
89 of 91 checks passed
@mukundansundar mukundansundar mentioned this pull request Oct 9, 2023
Closed
@elena-kolevska elena-kolevska mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshVanL JoshVanL JoshVanL approved these changes

@ItalyPaleAle ItalyPaleAle ItalyPaleAle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCP Certification Tests failing
5 participants
@elena-kolevska @JoshVanL @dapr-bot @artursouza @ItalyPaleAle