Move SQLite "auth" metadata to a separate package internal/authentication/sqlite
#3135
Conversation
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 63634f7 |
Components conformance testCommit ref: 63634f7 ❌ Some conformance tests failedThese tests failed:
|
Components certification testCommit ref: 63634f7 ❌ Some certification tests failedThese tests failed:
|
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
|
/ok-to-test |
Components certification testCommit ref: 63634f7 ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: 63634f7 ✅ All conformance tests passedAll tests have reported a successful status |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 63634f7 |
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 63634f7 |
Components certification testCommit ref: 63634f7 ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: 63634f7 ✅ All conformance tests passedAll tests have reported a successful status |
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 77cf89c |
Components certification testCommit ref: 77cf89c ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: 77cf89c ✅ All conformance tests passedAll tests have reported a successful status |
…ation/sqlite` (dapr#3135) Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Amit Mor <[email protected]>
Small refactoring of the SQLite component, to move the "auth" metadata (the struct containing the connection string and a few other basic fields) to a shared package. This is modeled after what has been done a while ago for Postgres.
Having a separate package helps with developing other SQLite-based components in the near future, such as the nameresolver.
A few additional changes:
InSecondssuffix (timeoutInSeconds) and some didn't (cleanupInterval).timeoutInSecondsis nowtimeoutand accepts a Go duration. Of course,timeoutInSecondscontinues to work as alias.connectionStringtourl(just because I myself kept making that mistake many times :) But the "official" name hasn't changed)More tests have been added for SQLite metadata, which were missing before.