Unify SQL DB migration subsystem (for Postgres and SQLite) #3134
Conversation
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
|
/ok-to-test |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
CockroachDB now fails @ItalyPaleAle |
Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]>
|
@berndverst thanks. All issues (linter & tests) should be fixed now |
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 8dd6e1e |
Components certification testCommit ref: 8dd6e1e ❌ Some certification tests failedThese tests failed:
|
Components conformance testCommit ref: 8dd6e1e ✅ All conformance tests passedAll tests have reported a successful status |
Signed-off-by: ItalyPaleAle <[email protected]>
Migrated sqlite too
…nto sql-migrator
|
/ok-to-test |
Components conformance testCommit ref: 5132ede ✅ All conformance tests passedAll tests have reported a successful status |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 5132ede |
Components certification testCommit ref: 5132ede ❌ Some certification tests failedThese tests failed:
|
Signed-off-by: ItalyPaleAle <[email protected]>
|
/ok-to-test |
Complete Build MatrixThe build status is currently not updated here. Please visit the action run below directly. Commit ref: 2b80bd8 |
Components conformance testCommit ref: 2b80bd8 ✅ All conformance tests passedAll tests have reported a successful status |
Components certification testCommit ref: 2b80bd8 ❌ Some certification tests failedThese tests failed:
|
This PR expands
internal/component/sqlto also add a unified subsystem to perform migrations for SQL databases. Currently, Postgres and SQLite are supported and have been migrated to that.Related changes that are included:
internal/component/sqlthat works with both database/sql and pgx. This has been added to the garbage collector too, to simplify the codeinternal/component/postgresqlto remove thedbAccesslayer which was adding complexity for no benefit (it didn't even help with unit tests)Overall this PR moves around a bunch of code, but doesn't really change much how things work.