Add appId to consul default checks #2490
Conversation
|
Is this a breaking change? |
|
@alberthuang24 can you please merge the latest dapr/components-contrib@master into this PR? |
|
I am still not a fan of this approach. How about just changing Consul to de-register the service (if present) before registering a new one? https://pkg.go.dev/github.com/hashicorp/consul/[email protected]#Agent.ServiceDeregister |
That does sound better. |
ItalyPaleAle
changed the title
|
I've done a bunch of work on this and looks like the solution of un-registering the service wouldn't work either, because that removes all instances of the service. I now agree with @alberthuang24 this may be the best approach to fix the issue. |
fix dapr#2489 Signed-off-by: AlbertHuang <[email protected]>
I rebase the latest master branch and will continue to resolve dapr/dapr#5868 when this PR is merged |
|
@ItalyPaleAle Hi, Can this PR be merged? |
|
@alberthuang24 please see the comments here: dapr/dapr#5868 We're asking for a small change, then we can merge this and the PR in dapr/dapr |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
/keep-alive |
Re-do of dapr#2490 to update Co-Authored-By: AlbertHuang <[email protected]> Signed-off-by: ItalyPaleAle <[email protected]>
Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: AlbertHuang <[email protected]>
fix #2489
Signed-off-by: AlbertHuang [email protected]
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: