Additional tests for Hashicorp Vaul Secret Store certification. #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This PR adds additional tests to complete vault certification. A detailed test plann is added to its README. * Fixes a vault behaviour regarding its multiple key-values per secret behaviour when its `valueType` flag is set to `text`. This is a follow up to dapr#2140. Closes dapr#1926. Signed-off-by: Tiago Alves Macambira <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2316 +/- ##
===========================================
+ Coverage 0 38.22% +38.22%
===========================================
Files 0 202 +202
Lines 0 25501 +25501
===========================================
+ Hits 0 9747 +9747
- Misses 0 14993 +14993
- Partials 0 761 +761
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
.github/infrastructure/conformance/hashicorp/setup-hashicorp-vault-secrets.sh
Show resolved
Hide resolved
tests/certification/secretstores/hashicorp/vault/components/caFamily/Makefile
Show resolved
Hide resolved
mcandeia
suggested changes
Nov 28, 2022
.../certification/secretstores/hashicorp/vault/components/caFamily/vaultConfig/vault_server.hcl
Outdated
Show resolved
Hide resolved
* Removes emojis from output * Auto-generate certificates on the fly * Move helper methods out of vault_test.go and into helper files. Signed-off-by: Tiago Alves Macambira <[email protected]>
tmacam
commented
Nov 29, 2022
...s/hashicorp/vault/components/enginePath/customSecretsPath/docker-compose-hashicorp-vault.yml
Outdated
Show resolved
Hide resolved
...cation/secretstores/hashicorp/vault/components/versioning/docker-compose-hashicorp-vault.yml
Outdated
Show resolved
Hide resolved
...cation/secretstores/hashicorp/vault/components/versioning/docker-compose-hashicorp-vault.yml
Outdated
Show resolved
Hide resolved
tmacam
commented
Nov 29, 2022
tests/certification/secretstores/hashicorp/vault/secret_helpers.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Tiago Alves Macambira <[email protected]>
tmacam
added a commit
to tmacam/dapr-docs
that referenced
this pull request
Nov 30, 2022
With dapr/components-contrib#2316 we should complete Hashicorp Vault certification and promote it to stable. Signed-off-by: Tiago Alves Macambira <[email protected]>
tmacam
added a commit
to tmacam/dapr-docs
that referenced
this pull request
Nov 30, 2022
With dapr/components-contrib#2316 we should complete Hashicorp Vault certification and promote it to stable. Signed-off-by: Tiago Alves Macambira <[email protected]>
This was referenced Nov 30, 2022
berndverst
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
valueTypeflag is set totext.This is a follow up to #2140.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1926
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: