binding.eventhub: use same name schema for storage leases like on pubsub.eventhub #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sub.eventhub Signed-off-by: Christian Leinweber <[email protected]>
There was a problem hiding this comment.
I agree that having consistency across binding and pubsub makes sense.
@berndverst @tanvigour WDYT?
Codecov Report
@@ Coverage Diff @@
## master #1940 +/- ##
==========================================
+ Coverage 37.08% 37.09% +0.01%
==========================================
Files 183 183
Lines 23344 23364 +20
==========================================
+ Hits 8656 8668 +12
- Misses 13989 13997 +8
Partials 699 699
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Christian Leinweber <[email protected]>
mukundansundar
approved these changes
Aug 7, 2022
|
Thank you! |
berndverst
approved these changes
Aug 8, 2022
mindovermiles262
pushed a commit
to mindovermiles262/components-contrib
that referenced
this pull request
Aug 18, 2022
…sub.eventhub (dapr#1940) * binding.eventhub: use same name schema for storage leases like on pubsub.eventhub Signed-off-by: Christian Leinweber <[email protected]> * binding.eventhub: rename AzureEventshub local var Signed-off-by: Christian Leinweber <[email protected]> Signed-off-by: Andrew Duss <[email protected]>
berndverst
added a commit
that referenced
this pull request
Aug 19, 2022
* Azure AD support in SignalR (#1852) * WIP: Azure AD support in SignalR Signed-off-by: ItalyPaleAle <[email protected]> * Correct SignalR AAD details Signed-off-by: ItalyPaleAle <[email protected]> * Misc fixes Signed-off-by: ItalyPaleAle <[email protected]> * azauth package name Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * use docker for linting for github action compatability Signed-off-by: Andrew <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * update makefile to check version rather than using docker Signed-off-by: Andrew Duss <[email protected]> * try windows again Signed-off-by: Andrew Duss <[email protected]> * Pin certification tests to v1.8.0-rc.4 Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Added conformance test for Azure Blob Storage state store Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * state.azure.blobstorage now passes conformance tests Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Added more logging to state conformance tests Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Reporting ETag failures correctly in delete method Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Fixing #1845 Signed-off-by: cmendible <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Pin certification tests to dapr v1.8.0 Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Ft/sasl scram sha 256 512 (#1856) * working with hardcoded SHA-512 Signed-off-by: Andrew Duss <[email protected]> * cleanup code Signed-off-by: Andrew Duss <[email protected]> * Do not hardcode specific testTopicName Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Ensure context propagation in MySQL binding (#1829) Spin-off from PR adding contexts to input bindings Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Add support for AAD auth in Azure Storage Queues binding (#1842) * Add support for AAD auth in Azure Storage Queues binding Signed-off-by: ItalyPaleAle <[email protected]> * 🧹 Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Moved authentication to be an internal pkg (#1855) Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Azure AD support in SignalR (#1852) * WIP: Azure AD support in SignalR Signed-off-by: ItalyPaleAle <[email protected]> * Correct SignalR AAD details Signed-off-by: ItalyPaleAle <[email protected]> * Misc fixes Signed-off-by: ItalyPaleAle <[email protected]> * azauth package name Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * rename SCRAM properly as SASL Signed-off-by: Andrew Duss <[email protected]> * update gomod/sum Signed-off-by: Andrew Duss <[email protected]> * gofmt Signed-off-by: Andrew Duss <[email protected]> * mod tidy Signed-off-by: Andrew Duss <[email protected]> * goval Signed-off-by: Andrew Duss <[email protected]> * use xdg-go instead of depreicated xdg library Signed-off-by: Andrew Duss <[email protected]> Co-authored-by: ItalyPaleAle <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Updated devcontainer for 1.8 Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Fixes 400 error empty content from sendgrid (#1867) Signed-off-by: Ben Coleman <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * optimize: add context to huawei/obs (#1820) * optimize: add context to huawei/obs Signed-off-by: 1046102779 <[email protected]> * optimize: add context to huawei/obs Signed-off-by: 1046102779 <[email protected]> * optimize: add context to huawei/obs Signed-off-by: 1046102779 <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Add contexts to input bindings (#1831) This is the last part of the "shutdown sequence fix": it allows shutting down input bindings before output ones. Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Updated pinned version of dapr/dapr in cert tests (#1877) Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * pubsub.redis: better ack for messages (#1886) Also do not log errors for "context canceled" during shutdown Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Add user agent to AWS requests (#1890) * Add user agent to AWS requests Signed-off-by: Clare Liguori <[email protected]> * Fix import spacing Signed-off-by: Clare Liguori <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * pubsub.mqtt: support wildcard and shared subscriptions (#1882) Fixes #1881 Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Added pubsub.FeatureSubscribeWildcards capability (#1887) Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Calculate Cert test coverage and notify discord monitoring channel (#1857) * Calulate Cert Test Coverage and Notify Discord Server Signed-off-by: Deepanshu Agarwal <[email protected]> * Mentioning Monitoring Webhook Url Signed-off-by: Deepanshu Agarwal <[email protected]> * Addressing comments Signed-off-by: Deepanshu Agarwal <[email protected]> * Add warning comment on low coverage Signed-off-by: Shubham Sharma <[email protected]> * Job NOT to fail, even when Discord Norification fails Signed-off-by: Deepanshu Agarwal <[email protected]> * Revert "Add warning comment on low coverage" This reverts commit 35d4742. Signed-off-by: Deepanshu Agarwal <[email protected]> * Fix Errors Signed-off-by: Deepanshu Agarwal <[email protected]> * Not failing anywhere in Final Covergae Step Signed-off-by: Deepanshu Agarwal <[email protected]> Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * azure appconfig configuration store (#1874) * azure appconfig configuration store Signed-off-by: cmendible <[email protected]> * added retry options Signed-off-by: cmendible <[email protected]> * removed unused property Signed-off-by: cmendible <[email protected]> * fixed error msgs, typos and test names Signed-off-by: cmendible <[email protected]> * resource documenation Signed-off-by: cmendible <[email protected]> * return err from not implemented functions Signed-off-by: cmendible <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Loong Dai <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * modify error msg (#1897) Signed-off-by: 1046102779 <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Use unique message key in Azure ServiceBus PubSub (#1898) Signed-off-by: Andrew Duss <[email protected]> * Do not skip duplicate actions for conf and cert tests Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Remove pre-condition from workflow (#1903) Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * pubsub.mqtt: support multiple wildcards in subscriptions (#1901) Fixes #1881 Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Certification test for Azure Blob storage state store component (#1896) * Certification test for Azure Blob storage state store component Signed-off-by: tanvigour <[email protected]> * fix comments Signed-off-by: tanvigour <[email protected]> * fix comments Signed-off-by: tanvigour <[email protected]> * rebase and run mod tidy Signed-off-by: tanvigour <[email protected]> * Update Readme Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Added conformance tests for rabbitmq bindings (#1910) * Added conformance tests for rabbitmq bindings Signed-off-by: Amulya Varote <[email protected]> * Fixing lint issues Signed-off-by: Amulya Varote <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * pubsub.snssqs: Support regions in other AWS partitions (#1925) Fixes #1907 Signed-off-by: Clare Liguori <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Updated CI: (#1918) Signed-off-by: Andrew Duss <[email protected]> * make linter timeout 15 min (#1931) Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * feat(pubsub/jetstream): allow tls client authentication (#1924) Signed-off-by: NickLarsenNZ <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Fix Apache Dubbo indirect dependency (#1934) Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Updated codecov Action to v3 and reduce email spam (#1936) Signed-off-by: Andrew Duss <[email protected]> * Ensure we're using the right version of cenkalti/backoff (#1904) Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Add auto-completion flag for Zeebe (#1908) Signed-off-by: Christian Kaps <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * add ipfs binding (#1849) * add web3.ipfs binding Signed-off-by: hypernova3 <[email protected]> * Replaced go module as old versions brought in a dep with LGPL license Signed-off-by: hypernova3 <[email protected]> * lint Signed-off-by: hypernova3 <[email protected]> * changed cid -> path Signed-off-by: hypernova3 <[email protected]> * add "ls" command Signed-off-by: hypernova3 <[email protected]> * pin-ls returns cids Signed-off-by: hypernova3 <[email protected]> * just "bindings.ipfs" Signed-off-by: hypernova3 <[email protected]> * updated library to kubo Signed-off-by: hypernova3 <[email protected]> * added tests Signed-off-by: hypernova3 <[email protected]> * linted Signed-off-by: hypernova3 <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Ensure rethinkdb complies with state.TransactionalStore (#1930) Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Implemented get all keys (#1920) Signed-off-by: cmendible <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Certification tests for env/file secrets stores #1761 (#1846) * Certification tests for env/file secrets store #1761 Signed-off-by: cmendible <[email protected]> * using testing setEnv Signed-off-by: cmendible <[email protected]> * removing nestedSeparator to test default behaviour Signed-off-by: cmendible <[email protected]> * make modtidy-all Signed-off-by: Bernd Verst <[email protected]> * Remove unnecessary replace in go.mod s Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * add a new binding component : alicloud sls log storage (#1873) * new a bingding componet alicloud sls logstorage Signed-off-by: RcXu <[email protected]> Signed-off-by: Bernd Verst <[email protected]> * update sls binding component Signed-off-by: RcXu <[email protected]> Signed-off-by: Bernd Verst <[email protected]> * update the metadata decode method Signed-off-by: RcXu <[email protected]> Signed-off-by: Bernd Verst <[email protected]> * make modtidy-all Signed-off-by: Bernd Verst <[email protected]> * sort imports Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: RcXu <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * binding.eventhub: use same name schema for storage leases like on pubsub.eventhub (#1940) * binding.eventhub: use same name schema for storage leases like on pubsub.eventhub Signed-off-by: Christian Leinweber <[email protected]> * binding.eventhub: rename AzureEventshub local var Signed-off-by: Christian Leinweber <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * bindings.cron: ensure it can resume correctly after context cancellation (#1943) Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Adding in track2 SDK support for CosmosDB Bindings (#1876) * Adding in track2 SDK support for CosmosDB Bindings Signed-off-by: Ryan Lettieri <[email protected]> * Removing non needed ID check Signed-off-by: Ryan Lettieri <[email protected]> * Addressing container read operation Signed-off-by: Ryan Lettieri <[email protected]> * Updating linting Signed-off-by: Ryan Lettieri <[email protected]> Co-authored-by: Ryan Lettieri <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * updated local secret stores certification test dependencies (#1948) Signed-off-by: Andrew Duss <[email protected]> * Enable CosmosDB Binding conformance test (#1946) Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Allow more folks to run `/ok-to-test` (#1944) Give access to `/ok-to-test` to several more people working on certification tests. Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Bump github.com/open-policy-agent/opa from 0.40.0 to 0.42.0 (#1945) * Bump github.com/open-policy-agent/opa from 0.40.0 to 0.42.0 Bumps [github.com/open-policy-agent/opa](https://github.com/open-policy-agent/opa) from 0.40.0 to 0.42.0. - [Release notes](https://github.com/open-policy-agent/opa/releases) - [Changelog](https://github.com/open-policy-agent/opa/blob/main/CHANGELOG.md) - [Commits](open-policy-agent/opa@v0.40.0...v0.42.0) --- updated-dependencies: - dependency-name: github.com/open-policy-agent/opa dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * make modtidy-all Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Enable conformance test for memcached state store (#1949) Signed-off-by: Andrew Duss <[email protected]> * Removing the use of the ioutil package And Fix CVE-2021-42576 (#1954) * fix CVE-2021-42576 Signed-off-by: qiangmzsx <[email protected]> * Removing the use of the ioutil package Signed-off-by: qiangmzsx <[email protected]> * Update middleware/http/nethttpadaptor/nethttpadaptor.go Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: qiangmzsx <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * fix daprbot (#1956) Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Ensure locks in channels are properly released (#1957) Fixes #1865 Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * fix: bindings.ipfs unit test (#1961) Signed-off-by: 1046102779 <[email protected]> Signed-off-by: 1046102779 <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * optimize: add e2etests buildtags for e2e (#1951) * optimize: skip fatal when pubsub/jetstream server don't start in unit test Signed-off-by: 1046102779 <[email protected]> * optimize: skip fatal when pubsub/jetstream server don't start in unit test Signed-off-by: 1046102779 <[email protected]> * optimize: skip fatal when pubsub/jetstream server don't start in unit test Signed-off-by: 1046102779 <[email protected]> * optimize: add e2etests buildtags for e2e Signed-off-by: 1046102779 <[email protected]> Signed-off-by: 1046102779 <[email protected]> Co-authored-by: Loong Dai <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Handle service bus exported errors (#1942) * Add service bus exported error handling Signed-off-by: Addison Juarez <[email protected]> * Add service bus exported error handling Signed-off-by: Addison Juarez <[email protected]> Signed-off-by: Addison Juarez <[email protected]> Co-authored-by: Loong Dai <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * pubsub.in-memory: add support for wildcard topics (#1966) * pubsub.in-memory: add support for wildcard topics Fixes #1964 Signed-off-by: ItalyPaleAle <[email protected]> * make modtidy-all Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Update code to reflect renaming on UnlockResponse.Status (#1958) PR dapr/dapr#4989 (issue dapr/dapr#4988) updated the names of some enums in `UnlockResponse.Status` ProtoBuff definition: * `LOCK_UNEXIST` became `LOCK_DOES_NOT_EXIST ` * `LOCK_BELONG_TO_OTHERS` became `LOCK_BELONGS_TO_OTHERS` Code implementing Distributed Lock component in components-contrib needs to be updated to account for this modification. This PR accomplishes this by updating contants mapping back to the two enums above to match their new names. Fixes components-contrib#1950 Signed-off-by: Tiago Alves Macambira <[email protected]> Signed-off-by: Tiago Alves Macambira <[email protected]> Co-authored-by: Loong Dai <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * fix(kafka): ConsumeClaim should not return err when retry recovery failed (#1965) * fix(kafka): ConsumeClaim should not return err when retry recovery failed Signed-off-by: zcong1993 <[email protected]> * chore: tweak error log message Signed-off-by: zcong1993 <[email protected]> Signed-off-by: zcong1993 <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Allow metadata to flow through service bus queue (#1911) * Allow metadata to flow through service bus queue This commit lets metadata bind to a message and be read when the message is received. This allows for the distributed tracing of events. Signed-off-by: Hal Spang <[email protected]> * Remove saved fields from ApplicationProperties Signed-off-by: Hal Spang <[email protected]> * Add a certification test for metadata Signed-off-by: Hal Spang <[email protected]> Signed-off-by: Hal Spang <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Fix CosmosDB state store handling of nulls (#1974) Signed-off-by: Andrew Duss <[email protected]> * Go 1.19 support and linter fixes (#1975) * Go 1.19 support and linter fixes Signed-off-by: Bernd Verst <[email protected]> * Update workflows for Go1.19 and new linter version Signed-off-by: Bernd Verst <[email protected]> * Remove unnecessary space in nolint directive Signed-off-by: Bernd Verst <[email protected]> * disable additional linters which aren't used because of Go generics Signed-off-by: Bernd Verst <[email protected]> * enable gosec linter again Signed-off-by: Bernd Verst <[email protected]> * Update bindings/zeebe/command/publish_message_test.go Signed-off-by: Bernd Verst <[email protected]> * Update bindings/output_binding.go Signed-off-by: Bernd Verst <[email protected]> * Use prepared statement for mysql table creation Signed-off-by: Bernd Verst <[email protected]> * Ping is not ping Signed-off-by: Bernd Verst <[email protected]> * c'mon linter Signed-off-by: Bernd Verst <[email protected]> * Fix MySQL gosec issue Signed-off-by: Bernd Verst <[email protected]> * revert mysql to be fixed later Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: Andrew Duss <[email protected]> * Fixes to MySQL state store (#1978) Signed-off-by: Andrew Duss <[email protected]> * instruct user to download if linter not installed Signed-off-by: Andrew Duss <[email protected]> * separated linter installed and version checking into targets Signed-off-by: Andrew Duss <[email protected]> * cleanup file Signed-off-by: Andrew Duss <[email protected]> * fixed bug where make would choke when linter not installed Signed-off-by: Andrew Duss <[email protected]> * fix typos Signed-off-by: Andrew Duss <[email protected]> * add specific version of linter to install Signed-off-by: Andrew Duss <[email protected]> Signed-off-by: ItalyPaleAle <[email protected]> Signed-off-by: Andrew Duss <[email protected]> Signed-off-by: Andrew <[email protected]> Signed-off-by: Bernd Verst <[email protected]> Signed-off-by: cmendible <[email protected]> Signed-off-by: Ben Coleman <[email protected]> Signed-off-by: Clare Liguori <[email protected]> Signed-off-by: Amulya Varote <[email protected]> Signed-off-by: Christian Leinweber <[email protected]> Signed-off-by: qiangmzsx <[email protected]> Signed-off-by: 1046102779 <[email protected]> Signed-off-by: Addison Juarez <[email protected]> Signed-off-by: Tiago Alves Macambira <[email protected]> Signed-off-by: zcong1993 <[email protected]> Signed-off-by: Hal Spang <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: Bernd Verst <[email protected]> Co-authored-by: cmendible <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Yaron Schneider <[email protected]> Co-authored-by: Ben Coleman <[email protected]> Co-authored-by: yellow chicks <[email protected]> Co-authored-by: Clare Liguori <[email protected]> Co-authored-by: deepanshuagarwal <[email protected]> Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Loong Dai <[email protected]> Co-authored-by: Joni Collinge <[email protected]> Co-authored-by: tanvigour <[email protected]> Co-authored-by: amulyavarote <[email protected]> Co-authored-by: Nick <[email protected]> Co-authored-by: Christian Kaps <[email protected]> Co-authored-by: hypernova3 <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Mr.Black <[email protected]> Co-authored-by: RcXu <[email protected]> Co-authored-by: Christian Leinweber <[email protected]> Co-authored-by: Ryan Lettieri <[email protected]> Co-authored-by: Ryan Lettieri <[email protected]> Co-authored-by: Carlos Mendible <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: qiangmzsx <[email protected]> Co-authored-by: addjuarez <[email protected]> Co-authored-by: Tiago Alves Macambira <[email protected]> Co-authored-by: cong <[email protected]> Co-authored-by: halspang <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We are currently adopting the naming change from this PR #1292 to the KEDA Eventhub Scaler. But the naming change includes only the pubsub component and not the eventhub binding. So there are two different naming schemas for storage leases, and this makes it more difficult to integrate that in the KEDA Scaler.
See this discussion on KEDA: kedacore/keda#3022
Before doing the KEDA change, it makes sense to use a unique naming schema for pubsub and binding. So I've made a proposal for it.
What do you think?